From owner-freebsd-ports@FreeBSD.ORG Sun Feb 19 03:11:42 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 3070E1065672; Sun, 19 Feb 2012 03:11:42 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-197-151.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 2AEAF14D901; Sun, 19 Feb 2012 03:11:41 +0000 (UTC) Message-ID: <4F40686C.6030800@FreeBSD.org> Date: Sat, 18 Feb 2012 19:11:40 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:10.0.2) Gecko/20120218 Thunderbird/10.0.2 MIME-Version: 1.0 To: Mark Linimon References: <20120217182214.GD11416@lonesome.com> <4F403B69.9030503@FreeBSD.org> <20120219030318.GB6927@lonesome.com> In-Reply-To: <20120219030318.GB6927@lonesome.com> X-Enigmail-Version: 1.3.5 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Michael Scheidell , Andriy Gapon , Steve Kargl , Chris Rees , "freebsd-ports@FreeBSD.org" Subject: Re: Please test your commits X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2012 03:11:42 -0000 On 02/18/2012 19:03, Mark Linimon wrote: > On Sat, Feb 18, 2012 at 03:59:37PM -0800, Doug Barton wrote: >> Where I think reasonable minds can differ are (appropriate) responses of >> the form, "This was not done properly, here is how it can/should be done >> (better)." IMO those should *always* be public in order to help others >> who are paying attention to the same topic. > > Fair enough. Perhaps I should have been more clear about the distinction > I make between constructive criticism ("this code would be more effectively > stated xyz") vs. non-constructive criticism ("your mother smells of > elderberries".) I thought it went without saying that those messages just shouldn't be sent. Doug (typed out maybe, but not sent) -- It's always a long day; 86400 doesn't fit into a short. Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/