From owner-svn-src-all@freebsd.org Wed Jan 31 22:52:36 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4AF2BEE6ED8; Wed, 31 Jan 2018 22:52:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F3C6E7D4B0; Wed, 31 Jan 2018 22:52:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 110DB10A7DB; Wed, 31 Jan 2018 17:52:29 -0500 (EST) From: John Baldwin To: Glen Barber Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328637 - head/lib/libgcc_s Date: Wed, 31 Jan 2018 13:49:25 -0800 Message-ID: <2842708.9sbgdJgr1q@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201801312141.w0VLfgkw051167@repo.freebsd.org> References: <201801312141.w0VLfgkw051167@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 31 Jan 2018 17:52:29 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 22:52:36 -0000 On Wednesday, January 31, 2018 09:41:42 PM Glen Barber wrote: > Author: gjb > Date: Wed Jan 31 21:41:42 2018 > New Revision: 328637 > URL: https://svnweb.freebsd.org/changeset/base/328637 > > Log: > Fix build by escaping a line break. > > PR: 225597 > Submitted by: cbnfinley at gmail.com > Sponsored by: The FreeBSD Foundation > > Modified: > head/lib/libgcc_s/Makefile > > Modified: head/lib/libgcc_s/Makefile > ============================================================================== > --- head/lib/libgcc_s/Makefile Wed Jan 31 21:14:59 2018 (r328636) > +++ head/lib/libgcc_s/Makefile Wed Jan 31 21:41:42 2018 (r328637) > @@ -35,7 +35,7 @@ SRCS+= s_scalbnf.c > > # Don't include long double routines on architectures where long double > # is the same size as double. > -.if ${MACHINE_CPUARCH} != "mips" && ${MACHINE_CPUARCH} != "arm" && > +.if ${MACHINE_CPUARCH} != "mips" && ${MACHINE_CPUARCH} != "arm" && \ > ${MACHINE_CPUARCH} != "powerpc" > SRCS+= s_fmaxl.c > SRCS+= s_logbl.c Thanks. I've been building MIPS worlds with this change for months. I've no idea why bmake would work for that case but fail for others. You'd think if it was a syntax error it would fail reliably? Perhaps it is doing short-circuit eval such that it didn't parse the rest of the line? -- John Baldwin