Date: Tue, 3 Jul 2018 15:13:19 +0200 From: "Timur I. Bakeyev" <timur@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r473793 - in head/devel: . cwrap nss_wrapper pam_wrapper resolv_wrapper socket_wrapper uid_wrapper Message-ID: <CALdFvJHyigahEAMJ7o31upH9mCU2giP3mSHkq_sguhgy2amesw@mail.gmail.com> In-Reply-To: <20180703065839.2oqenluilcdzkl6d@atuin.in.mat.cc> References: <201807030329.w633ThS8056768@repo.freebsd.org> <20180703065839.2oqenluilcdzkl6d@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 July 2018 at 08:58, Mathieu Arnold <mat@freebsd.org> wrote:
> On Tue, Jul 03, 2018 at 03:29:43AM +0000, Timur I. Bakeyev wrote:
> > Added: head/devel/nss_wrapper/Makefile
> > ============================================================
> ==================
> > --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> > +++ head/devel/nss_wrapper/Makefile Tue Jul 3 03:29:42 2018
> (r473793)
> > +
> > +CMAKE_ARGS+= -DMAN_INSTALL_DIR:PATH="${PREFIX}/man"
>
> Why +=?
>
Fixed.
> +OPTIONS_DEFINE= TEST
> > +OPTIONS_DEFAULT= TEST
> > +
> > +TEST_TARGET= test
>
> Fun fact, TEST_TARGET may not do what you think it does. What it does
> is tell the framework that the target to run when running `make test` is
> test, which will probably fail if the TEST option is not enabled. What
> you may have meant to set was TEST_TEST_TARGET, which sets TEST_TARGET
> when the TEST option is enabled.
>
Fixed.
> +TEST_CMAKE_BOOL= UNIT_TESTING
> > +TEST_BUILD_DEPENDS+= cmocka>=1.1.1:sysutils/cmocka
>
> Why +=?
>
Fixed.
> These are a lot of files, you should probably be using a pkg-plist file
> instead.
>
I don't feel that 7(8) lines is an excessive amount of lines. I'd rather
save inodes here.
> Added: head/devel/pam_wrapper/Makefile
>
> Way too many files to be using PLIST_FILES, please use a pkg-plist file.
>
> Ok, this one is excessive, moved to pkg-plist.
The rest are fixed in the same manner as nss_wrapper.
BaT
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALdFvJHyigahEAMJ7o31upH9mCU2giP3mSHkq_sguhgy2amesw>