From owner-freebsd-current@FreeBSD.ORG Wed Nov 19 01:35:49 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10A0016A4CE for ; Wed, 19 Nov 2003 01:35:49 -0800 (PST) Received: from mail.a-quadrat.at (mail.a-quadrat.at [81.223.141.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 02FB743F75 for ; Wed, 19 Nov 2003 01:35:48 -0800 (PST) (envelope-from mbretter@a-quadrat.at) Received: from BRUTUS.a-quadrat.at (brutus.a-quadrat.at [192.168.90.60]) by files.a-quadrat.at (Postfix) with ESMTP id 28DA25C03C; Wed, 19 Nov 2003 10:35:05 +0100 (CET) Date: Wed, 19 Nov 2003 10:35:42 +0100 (=?ISO-8859-15?Q?Westeurop=E4ische_Normalzeit?=) From: Michael Bretterklieber To: Boris Kovalenko In-Reply-To: <3FBB3317.4090001@ntmk.ru> Message-ID: References: <3FBAEAC1.7090709@tagnet.ru> <20031119071703.GA38863@pit.databus.com> <3FBB1DF3.1050706@ntmk.ru> <3FBB2743.8040508@ntmk.ru> <3FBB3317.4090001@ntmk.ru> X-X-Sender: mbretter@files.a-quadrat.at MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-current Subject: Re: ppp RADIUS accounting bug X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Nov 2003 09:35:49 -0000 Hi, On Wed, 19 Nov 2003, Boris Kovalenko wrote: > > >The RFC says: > > > >5.4. Acct-Output-Octets > > > >blabla > > > >can only be > > present in Accounting-Request records where the Acct-Status-Type > > is set to Stop. > > > >It looks like, that these counters must not present in accounting updates. > > > You are right, but your words - "but a patch could be written :-)". > Again, I'm talking not about UPDATE packets and presence of any > attributes in RADIUS requests. I'm talking about wrong handling of > Acct-Input-Octets & Acct-Output-Octets with current PPP RADIUS > implementation. How this will be done, by implementing RFC2869 support IMHO this would be the right way, because RFC 2869 definitely says: "Note that all information in an interim message is cumulative (i.e. number of packets sent is the total since the beginning of the session, not since the last interim message)." So sending interim update packets won't help. > looking for someone who supervises my patch and commit it if no problems > will be founded. this can be a problem :-) bye, -- ------------------------------- ---------------------------------- Michael Bretterklieber - http://www.bretterklieber.com A-Quadrat Automation GmbH - http://www.a-quadrat.at Tel: ++43-(0)3172-41679 - GSM: ++43-(0)699 12861847 ------------------------------- ---------------------------------- "...the number of UNIX installations has grown to 10, with more expected..." - Dennis Ritchie and Ken Thompson, June 1972