From nobody Mon Sep 26 21:20:53 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MbwfJ48HHz4V6Jb; Mon, 26 Sep 2022 21:20:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MbwfJ3XmHz3nhg; Mon, 26 Sep 2022 21:20:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664227256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWxqSHSXgUfeAUBU77jlnk1PsUaDS3sFksmJEKpRWPg=; b=QFJ5DwpqRZXCj8CrqbWc05E3jTOP4dLnCuoAgf1kaTscCrV+pmFxjUPKRcpxtnS88n4KGk SKPAWxyY1QToBLlkgxACZTsJ+OAl19Ex4pMadcjuRYuFVU3Rieftay0fw3uDIgj2aTRLRD 7EaZi+4OQpAnVf13UfB6WCMPf67Nbez2gydpHLHG6FifPkkfcACJHOHdxdbQI2DgbMfnwF FfnX1KReIcXrEBFKAAuG/+dF/8FVWNKBGPwezFfqbYjX5vbWdPAKF3jpSsQTJH6UZjWxmx JvYuWvqQzyapkvVZVL8MycUS/iqfrQHE9CzUvJoonZ5HDikslvn1EU0HdQTBWg== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MbwfH6JLtzk26; Mon, 26 Sep 2022 21:20:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <fd01ae42-6e1c-e7ee-f353-daba76edb46e@FreeBSD.org> Date: Mon, 26 Sep 2022 14:20:53 -0700 List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: <mailto:dev-commits-src-all+help@freebsd.org> List-Post: <mailto:dev-commits-src-all@freebsd.org> List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org> List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org> Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: git: 6bddde307e21 - main - Bump __FreeBSD_version for pmap_unmap*() and kmem_*() API changes. Content-Language: en-US To: Renato Botelho <garga@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202209222210.28MMApTd093914@gitrepo.freebsd.org> <9b11ed8e-1e32-f290-8a5d-997d46e58ac4@FreeBSD.org> From: John Baldwin <jhb@FreeBSD.org> In-Reply-To: <9b11ed8e-1e32-f290-8a5d-997d46e58ac4@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664227256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWxqSHSXgUfeAUBU77jlnk1PsUaDS3sFksmJEKpRWPg=; b=V0+fasDBKLyXx73cPBSsWAdMhIlNFy+Jw0ywOeESxQYqSgqoXXcdk90Gnj0GRQZkkp0DEy DjFZElj/ipVAstwx0QuTPs8HaYu/5SGRMXFPUx8AtJkDfep2fOy8JC0ssSZ2QP/H5x3ogX MBtmFvR+9M7MsfLBfkmMyESB12b90vZTCH47cgkKkKqlYiLxAI+G8YfoDfHCW5mdeh7uOM 9r/P2CQ/B11d/592eiVCAIRx2YSkeHHWn9CZlJm5kXN2dfxLeHRm9bdBp1l3kn8hpvyB8V JkwVKbcEgepARp9eMkjiTd57RUObQEMTgV423h3hi5tAPfoteQ+mISfpJJZsrA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664227256; a=rsa-sha256; cv=none; b=qzqMxr2ckXy5E0Pi6O4EDcwmM5tBfk2/cXoI8sVbTG9wyVbL7mPBY+O4aAg8CgAsAP18+H J31xVfoz81fK4tmUVPxp/VZ2FikVcfAQkpmfyu9eu4dk0LL6LTdLKESL3ZLZ9XMxUNzjpG rX4EkUJfskt18mg0mdGUvC2Q+tXhDR965UjwRSuzjmrUyXxdeIW3G2gY1tHPoJAyLzX3yl ZFkzkjhQge4XBtmTQRZPOAQpQB3Gxr6Pq5GEW3+TKEHgPptffnKkZl+2QdzvtK6Ih5EbvF pHqNdnzbwq9GMu5KzcjOI34VFWlD8vxRRDOu30hYzrWmRFNPwEkKhc/9Zju3fQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 9/26/22 6:54 AM, Renato Botelho wrote: > On 22/09/22 19:10, John Baldwin wrote: >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=6bddde307e21eba297ac3f3e534b4cf3be81dfe2 >> >> commit 6bddde307e21eba297ac3f3e534b4cf3be81dfe2 >> Author: John Baldwin <jhb@FreeBSD.org> >> AuthorDate: 2022-09-22 22:10:03 +0000 >> Commit: John Baldwin <jhb@FreeBSD.org> >> CommitDate: 2022-09-22 22:10:03 +0000 >> >> Bump __FreeBSD_version for pmap_unmap*() and kmem_*() API changes. > > Hello John, > > emulators/open-vm-tools is broken after these changes: > > --- vmmemctl --- > os.c:445:14: error: incompatible integer to pointer conversion passing > 'vm_offset_t' (aka 'unsigned int') to parameter of type 'void *' > [-Werror,-Wint-conversion] > KMEM_FREE((vm_offset_t)p->bitmap, p->size); > ^~~~~~~~~~~~~~~~~~~~~~ > os.c:143:46: note: expanded from macro 'KMEM_FREE' > #define KMEM_FREE(offset, size) kmem_free(offset, size) > ^~~~~~ > /usr/src/sys/vm/vm_extern.h:73:22: note: passing argument to parameter > 'addr' here > void kmem_free(void *addr, vm_size_t size); > ^ > 1 error generated. > > I can take a look at it during the week, any advice is appreciated. Hmm, ok. I had built all the kmod ports with this change locally before merging it and that one had built ok. :( I'll look at it this week. Oh, I just didn't create a commit for my changes to that port. I'll upload a review shortly. https://reviews.freebsd.org/D36734 -- John Baldwin