From owner-cvs-all Fri Jan 3 10:10:23 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDFB037B405; Fri, 3 Jan 2003 10:10:21 -0800 (PST) Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3490A43ED1; Fri, 3 Jan 2003 10:10:21 -0800 (PST) (envelope-from jake@k6.locore.ca) Received: from k6.locore.ca (jake@localhost.locore.ca [127.0.0.1]) by k6.locore.ca (8.12.6/8.12.6) with ESMTP id h03IT3uP081707; Fri, 3 Jan 2003 13:29:03 -0500 (EST) (envelope-from jake@k6.locore.ca) Received: (from jake@localhost) by k6.locore.ca (8.12.6/8.12.6/Submit) id h03IT21o081706; Fri, 3 Jan 2003 13:29:02 -0500 (EST) Date: Fri, 3 Jan 2003 13:29:02 -0500 From: Jake Burkholder To: Doug Rabson Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/zs zs.c Message-ID: <20030103132902.A81594@locore.ca> References: <200301021904.h02J4Z1W084332@repoman.freebsd.org> <1041592331.1584.0.camel@builder02.qubesoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <1041592331.1584.0.camel@builder02.qubesoft.com>; from dfr@nlsystems.com on Fri, Jan 03, 2003 at 11:12:12AM +0000 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Apparently, On Fri, Jan 03, 2003 at 11:12:12AM +0000, Doug Rabson said words to the effect of; > On Thu, 2003-01-02 at 19:04, Jake Burkholder wrote: > > jake 2003/01/02 11:04:35 PST > > > > Modified files: > > sys/dev/zs zs.c > > Log: > > - This damnable chip only has 1 status register for both ports, so the bit > > positions for the status bits of port a and port b are different. To > > avoid needing to know which channel the interrupt handler is working on, > > shift the status bits for port a into the port b bit positions, and always > > check the port b status bits. This fixes using port b, which I neglected > > to test before. > > - Remember to update the channel's tty structure from the passed in termios > > in the param routine. > > - Minor style. > > I wonder how much effort it would take to make the alpha zs driver (used > for console on some AlphaServers work for both alpha and sparc64. Oh. I didn't even realize that was there, its not in the hardware list. From the looks of it more work than the netbsd driver :). Does it use interrupts? Actually the netbsd driver outdates it, I'm surprised you didn't use it in the first place.. Jake To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message