From owner-svn-ports-head@freebsd.org  Wed Oct 19 06:12:39 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25C88C183AD;
 Wed, 19 Oct 2016 06:12:39 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from anoxia.adamw.org (anoxia.adamw.org [104.225.8.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "anoxia.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A4F63E38;
 Wed, 19 Oct 2016 06:12:38 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by anoxia.adamw.org (OpenSMTPD) with ESMTPSA id 4357d951
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Wed, 19 Oct 2016 00:12:31 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\))
Subject: Re: svn commit: r424182 - in head: Mk Mk/Uses accessibility/jovie
 accessibility/kaccessible accessibility/kmag accessibility/kmousetool
 accessibility/kmouth archivers/ark astro/kstars astro/marble audi...
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201610181722.u9IHMa0t093801@repo.freebsd.org>
Date: Wed, 19 Oct 2016 00:12:29 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <73BDBF7D-18B3-46DB-96E1-977A5580BE8C@adamw.org>
References: <201610181722.u9IHMa0t093801@repo.freebsd.org>
To: "Tobias C. Berner" <tcberner@freebsd.org>
X-Mailer: Apple Mail (2.3226)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Oct 2016 06:12:39 -0000

> On 18 Oct, 2016, at 11:22, Tobias C. Berner <tcberner@freebsd.org> =
wrote:
>=20
> Author: tcberner
> Date: Tue Oct 18 17:22:35 2016
> New Revision: 424182
> URL: https://svnweb.freebsd.org/changeset/ports/424182
>=20
> Log:
>  Introduce new extensible virtual categories for KDE
>=20
>  A lot of KDE Ports share MASTERSITES, LICENSE and so one, as they are
>  released as a bundle upstream, however, there was not really a clean
>  way to share this information.
>=20
>  Using these new categories, we can simplify the Makefiles for the =
diverse
>  KDE ports.
>  At the moment we support the virtual category
>  	* kde-kde4
>  In the future, this will be extended to
>  	* kde-frameworks
>  	* kde-plasma
>  	* kde-applications
>=20
>  PR:						213406
>  Differential Revision:	https://reviews.freebsd.org/D7645
>  Exp-run by :			antoine
>  Reviewed by:			mat, rakuco
>  Approved by: 			portmgr (mat), rakuco (mentor)
>=20

I hate to be that guy, but....

Are you sure that turning category into a magical setting is the best =
way to go? Category has never been magical before, and it sets a whole =
new precedent (until now, "Why aren't my distfiles showing up where I =
expect?" has never been answered with "CATEGORY").

Wouldn't something like
	USES=3D	kde:dist-kde4
be a more predictable way of doing this?

USES enables magic. CATEGORY sets the category. Do we really want to =
change that?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org