From owner-cvs-all Thu Sep 26 2:48:34 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 679FF37B401; Thu, 26 Sep 2002 02:48:33 -0700 (PDT) Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9558943E3B; Thu, 26 Sep 2002 02:48:32 -0700 (PDT) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id g8Q9mVg43108; Thu, 26 Sep 2002 05:48:31 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Thu, 26 Sep 2002 05:48:31 -0400 (EDT) From: Jeff Roberson To: Jeff Roberson Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/tools vnode_if.awk src/sys/sys vnode.h src/sys/kern vfs_subr.c In-Reply-To: <200209260448.g8Q4mihw055265@freefall.freebsd.org> Message-ID: <20020926054628.K97589-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 25 Sep 2002, Jeff Roberson wrote: > jeff 2002/09/25 21:48:44 PDT > > Modified files: > sys/tools vnode_if.awk > sys/sys vnode.h > sys/kern vfs_subr.c > Log: > - Move ASSERT_VOP_*LOCK* functionality into functions in vfs_subr.c > - Make the VI asserts more orthogonal to the rest of the asserts by using a > new, common vfs_badlock() function and adding a 'str' arg. > - Adjust generated ASSERTS to match the new prototype. > - Adjust explicit ASSERTS to match the new prototype. I forgot to credit bde for pointing out the many style bugs in vnode.h, some of which were addressed in this patch. I think vnode.h has grown a bit too big. So has vfs_subr.c. I'm thinking about moving the syncer in to vfs_syncer.c and possibly moving the debugging stuff into vfs_debug.c. Jeff To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message