From owner-cvs-all@FreeBSD.ORG  Tue May  6 14:04:37 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8FF5B37B401
	for <cvs-all@FreeBSD.org>; Tue,  6 May 2003 14:04:37 -0700 (PDT)
Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1A7F243F85
	for <cvs-all@FreeBSD.org>; Tue,  6 May 2003 14:04:36 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 26807 invoked from network); 6 May 2003 21:04:44 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <nate@root.org>; 6 May 2003 21:04:44 -0000
Received: from laptop.baldwin.cx ([216.133.140.1])
	by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h46L4Wp0001617;
	Tue, 6 May 2003 17:04:33 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030506170438.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200305062100.h46L0a1Z065872@khavrinen.lcs.mit.edu>
Date: Tue, 06 May 2003 17:04:38 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Garrett Wollman <wollman@lcs.mit.edu>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Nate Lawson <nate@root.org>
Subject: Re: cvs commit: src/sys/pci if_sis.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2003 21:04:37 -0000


On 06-May-2003 Garrett Wollman wrote:
> <<On Tue, 6 May 2003 13:57:47 -0700 (PDT), Nate Lawson <nate@root.org> said:
> 
>> I would rather you deleted the first call to callout_handle_init() instead
>> (after the "Inform the world" comment).  Reasons include poor style for
>> the first one and uniformity with other sys/pci/if_* drivers which do the
>> init right before ether_ifattach().
> 
> I would rather that drivers were fixed to use the new (FreeBSD 4)
> callout API, so that we can eventually deprecate the old one.

Agreed.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/