From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 7 22:40:39 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2416016A417 for ; Tue, 7 Nov 2006 22:40:39 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0684243D70 for ; Tue, 7 Nov 2006 22:40:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kA7MeNtv023206 for ; Tue, 7 Nov 2006 22:40:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kA7MeN7v023205; Tue, 7 Nov 2006 22:40:23 GMT (envelope-from gnats) Resent-Date: Tue, 7 Nov 2006 22:40:23 GMT Resent-Message-Id: <200611072240.kA7MeN7v023205@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Victor Balada Diaz Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BE2F716A415 for ; Tue, 7 Nov 2006 22:32:48 +0000 (UTC) (envelope-from victor@alf.dyndns.ws) Received: from alf.dyndns.ws (244.Red-217-126-240.staticIP.rima-tde.net [217.126.240.244]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A3FC43D49 for ; Tue, 7 Nov 2006 22:32:47 +0000 (GMT) (envelope-from victor@alf.dyndns.ws) Received: from alf.dyndns.ws (tp08bypqxfoehn6x@alf [217.126.240.244]) by alf.dyndns.ws (8.13.1/8.13.1) with ESMTP id kA7MWe8I065172 for ; Tue, 7 Nov 2006 23:32:45 +0100 (CET) (envelope-from victor@alf.dyndns.ws) Received: (from victor@localhost) by alf.dyndns.ws (8.13.1/8.13.1/Submit) id kA7MWeQx065171; Tue, 7 Nov 2006 23:32:40 +0100 (CET) (envelope-from victor) Message-Id: <200611072232.kA7MWeQx065171@alf.dyndns.ws> Date: Tue, 7 Nov 2006 23:32:40 +0100 (CET) From: Victor Balada Diaz To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/105262: MAINTAINER UPDATE: fix boot script on mail/milter-bogom X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2006 22:40:39 -0000 >Number: 105262 >Category: ports >Synopsis: MAINTAINER UPDATE: fix boot script on mail/milter-bogom >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Nov 07 22:40:22 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Victor Balada Diaz >Release: FreeBSD 5.3-RELEASE-p29 i386 >Organization: >Environment: not applicable >Description: the boot script evaluated milterbogom_flags before reading the configuration from rc.conf, so if you changed things like milterbogom_user it will not take the changes. This was noticed by Andrey Chernov and he also sent the patch to fix it. >How-To-Repeat: >Fix: --- milter-bogom.sh.in.patch begins here --- Index: milter-bogom.sh.in =================================================================== RCS file: /home/ncvs/ports/mail/milter-bogom/files/milter-bogom.sh.in,v retrieving revision 1.1 diff -u -r1.1 milter-bogom.sh.in --- milter-bogom.sh.in 25 May 2005 08:12:34 -0000 1.1 +++ milter-bogom.sh.in 7 Nov 2006 22:25:39 -0000 @@ -5,24 +5,24 @@ # BEFORE: sendmail # KEYWORD: milterbogom -milterbogom_enable=${milterbogom_enable-"NO"} -milterbogom_socket=${milterbogom_socket-"unix:/var/run/bogom/milter.sock"} -milterbogom_user=${milterbogom_user-"bogomilter"} -milterbogom_pid=${milterbogom_pid-"/var/run/bogom/bogom.pid"} -milterbogom_flags=${milterbogom_flags-"-u ${milterbogom_user} \ --s ${milterbogom_socket} -p ${milterbogom_pid}"} - - . %%RC_SUBR%% name=milterbogom -pidfile=${milterbogom_pid} rcvar=`set_rcvar` command=%%PREFIX%%/sbin/bogom start_precmd="bogom_precmd" stop_postcmd="bogom_postcmd" load_rc_config $name + +milterbogom_enable=${milterbogom_enable-"NO"} +milterbogom_socket=${milterbogom_socket-"unix:/var/run/bogom/milter.sock"} +milterbogom_user=${milterbogom_user-"bogomilter"} +milterbogom_pid=${milterbogom_pid-"/var/run/bogom/bogom.pid"} +milterbogom_flags=${milterbogom_flags-"-u ${milterbogom_user} \ +-s ${milterbogom_socket} -p ${milterbogom_pid}"} + +pidfile=${milterbogom_pid} bogom_precmd() { --- milter-bogom.sh.in.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: