From owner-freebsd-firewire@FreeBSD.ORG  Tue Aug 12 00:34:37 2008
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19448106566C;
	Tue, 12 Aug 2008 00:34:37 +0000 (UTC)
	(envelope-from freebsd@sopwith.solgatos.com)
Received: from parsely.rain.com (parsely.rain.com [199.26.172.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B6778FC16;
	Tue, 12 Aug 2008 00:34:36 +0000 (UTC)
	(envelope-from freebsd@sopwith.solgatos.com)
Received: from sopwith.solgatos.com (uucp@localhost)
	by parsely.rain.com (8.11.4/8.11.4) with UUCP id m7C0YUT31776;
	Mon, 11 Aug 2008 17:34:30 -0700 (PDT)
	(envelope-from freebsd@sopwith.solgatos.com)
Received: from localhost by sopwith.solgatos.com (8.8.8/6.24)
	id AAA07139; Tue, 12 Aug 2008 00:33:22 GMT
Message-Id: <200808120033.AAA07139@sopwith.solgatos.com>
To: Sean Bruno <sbruno@miralink.com>
In-reply-to: Your message of "Sat, 09 Aug 2008 13:12:28 PDT."
	<489DFA2C.4080407@miralink.com> 
Date: Mon, 11 Aug 2008 17:33:22 +0100
From: Dieter <freebsd@sopwith.solgatos.com>
Cc: Scott Long <scottl@freebsd.org>, freebsd-firewire@freebsd.org
Subject: Re: This is where I'm going with fwcontrol 
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Firewire support in FreeBSD <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2008 00:34:37 -0000

> Also, I changed some of the variable to check for >= 0 and set their 
> default values to -1.  This should have the same effect as adding a new 
> variable as you did in your fix.

If you're going to do it that way, the code should check that the argument
is in range, and print a complaint if out of range.  Otherwise the user could
say "fwcontrol -f -1" and nothing would happen.  And the man page should list
the legal range.  Hmmm, actually these should be done even with the
add-a-new-variable method.