From owner-freebsd-current@FreeBSD.ORG Mon Jan 17 19:33:44 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7495A106564A for ; Mon, 17 Jan 2011 19:33:44 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 030AB8FC12 for ; Mon, 17 Jan 2011 19:33:43 +0000 (UTC) Received: by fxm16 with SMTP id 16so6484538fxm.13 for ; Mon, 17 Jan 2011 11:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:subject:references:in-reply-to:x-enigmail-version :content-type:content-transfer-encoding; bh=SABRlWLKd4UtX8v4JrIB5+UC1gefqbFOrmj29P8PyH0=; b=YyX12rIK879G8+rirXVi30eooGh9Y1Fu7qqzFfIAnJcgkvfJuTs8SNzv67hLAjGoxu afxnXcUeX3v0oiL42fScBzPFth5JzXeX82OetDV8h5vstSIzHkUZTf8Hl5AaFQc/Zj/K FZrlSLz1xqnsSWejdXG8j79TzYBUxKF2woEcM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=GwZ0Y7T+jqAqtBEfoIB+kYQvPfYqU5R51gy+GULJZPO0vjakMCgk6Y31vZyRt4jsz2 Wmaz/LWyKa5A0kEKrSl5DRN5C7IcTR5QALoPnGUz6ZBEeyUEZ4CIlqOEO+MofGYa4nDz hY0+Ylw3P9puo908LEm7UlONOq+EY5XZK86n0= Received: by 10.223.73.202 with SMTP id r10mr5317701faj.133.1295292822749; Mon, 17 Jan 2011 11:33:42 -0800 (PST) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id y1sm1816217fak.15.2011.01.17.11.33.40 (version=SSLv3 cipher=RC4-MD5); Mon, 17 Jan 2011 11:33:41 -0800 (PST) Sender: Alexander Motin Message-ID: <4D349969.8090809@FreeBSD.org> Date: Mon, 17 Jan 2011 21:32:57 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Michael Butler , current References: In-Reply-To: X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: cosmetic nit in mmc.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2011 19:33:44 -0000 Michael Butler wrote: > In the process of making the sdhci driver work with my laptop, I noted a > cosmetic issue where the SD card's serial number is not correctly > reported (it's always zero). Possible patch attached, Thank you. I've committed such patch to the HEAD at r217509: --- mmc.c Mon Jan 17 19:17:26 2011 (r217508) +++ mmc.c Mon Jan 17 19:31:34 2011 (r217509) @@ -749,7 +749,7 @@ mmc_get_bits(uint32_t *bits, int bit_len uint32_t retval = bits[i] >> shift; if (size + shift > 32) retval |= bits[i - 1] << (32 - shift); - return (retval & ((1 << size) - 1)); + return (retval & ((1llu << size) - 1)); } static void -- Alexander Motin