From owner-svn-src-head@freebsd.org Wed Mar 14 23:12:05 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF292F50DB8 for ; Wed, 14 Mar 2018 23:12:05 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F1E867C6E3 for ; Wed, 14 Mar 2018 23:12:04 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wr0-x230.google.com with SMTP id s18so6367514wrg.9 for ; Wed, 14 Mar 2018 16:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3heOQTW182WIoLtztSyvVajSB//2/CI2J2dUJEfROq8=; b=PXie4MIi0hO9lZcZlUD0fXCjWcPHMMPFJK8Z/1SMrYcevCikU1bI/ZbtrMjRyDMMWr SqDS4fYqoRLN5An1m9dU4pKrErhALTf1tNxVyAMgUM/DA9aT6OiZ/W3tPPy9jdPq1XXI pLs9gCWF5Z0RE8hluj77Dwcf+K3B09TiFbs/pQFVvBHcXvNy1DrSDA07frt8ynToH+tN C/LzXC/Y9V70TY54EA6NE/GIlWeUUgfwqJxK1PTMw/4+BUy5SrJ3wFH+EP77B6IOCSwF tDgb05tdnOrrpV1M7dn8/2LF4JgM8eHFbBwVDg3K1c6meIpZFQBmzrDFUA1qm7pYh585 TcFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3heOQTW182WIoLtztSyvVajSB//2/CI2J2dUJEfROq8=; b=rpASEFcbwsRhrNBUM8QQLn0EIVbKqYszewYgIaMegEKB1ZfVGc33x9jhdKEtOLX0aC peEOJXFYUdh1fxHPyJriN5NuFaSN6KSiJlHt9Sp58YuCf+zWVGPc2b/44YxwsiM8zgmd fp9mxn95CzNeLHRNzwcSFz9wH6+2bLTYKR8tcmijmJeXX8ImPTaxedILXB2QNVw639Rb zPZcg14BWT/hwUDSecdDBlpn1eUTM7vGzTMiL+HG8LjF6j8IQ6BZE1unNqeZDaSXO8H7 Sv5paZyJ41BqwDbTmV0q0yl5TqO386mnvnHpi+pE2p6I+SqbjhhJHBZyhTqkBDdO4hyn +6iQ== X-Gm-Message-State: AElRT7ECxBHoQyjy/MhiykPi2SXRmphG+tClqwlAI/AYtohXcB20GsKH GOIfYI9SxLDHrZvglCm2Uo6/sQ== X-Google-Smtp-Source: AG47ELtM/XRVI35t5243L0k4rbw+i/WfKNeq2re5oA9wFoNlTqVVxTRq6ETs8cBMOXtPW1dn6EOQHw== X-Received: by 10.223.136.146 with SMTP id f18mr5431548wrf.57.1521069123780; Wed, 14 Mar 2018 16:12:03 -0700 (PDT) Received: from mutt-hbsd (torsrv0.snydernet.net. [185.100.86.154]) by smtp.gmail.com with ESMTPSA id d4sm2561482wmh.42.2018.03.14.16.12.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 16:12:03 -0700 (PDT) Date: Wed, 14 Mar 2018 19:11:50 -0400 From: Shawn Webb To: Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys Message-ID: <20180314231150.whi6ndflt77iyybw@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> <20180314225009.gu3awgryggsxqmff@mutt-hbsd> <20180314225623.zp6ufw5h7bua4etf@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gu7ci6sptypsxkle" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20171215 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 23:12:06 -0000 --gu7ci6sptypsxkle Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 14, 2018 at 05:06:09PM -0600, Alan Somers wrote: > On Wed, Mar 14, 2018 at 4:56 PM, Shawn Webb > wrote: >=20 > > On Wed, Mar 14, 2018 at 04:51:27PM -0600, Alan Somers wrote: > > > On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb > > > wrote: > > > > > > > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > > > > Author: asomers > > > > > Date: Sun Feb 25 14:29:43 2018 > > > > > New Revision: 329984 > > > > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > > > > > > > > > Log: > > > > > Don't declare __assfail as static > > > > > > > > > > It gets called by dmu_buf_init_user, which is inline but not > > static. > > > > So it > > > > > needs global linkage itself. > > > > > > > > > > Reported by: GCC-6 > > > > > MFC after: 17 days > > > > > X-MFC-With: 329722 > > > > > > > > > > > > > Hey Alan, > > > > > > > > This commit breaks compiling world with ASAN. > > > > > > > > Some applications, like zfs, will fail with this error: > > > > > > > > /lib/libuutil.so.2: Undefined symbol "__assfail" > > > > > > > > Thanks, > > > > > > > > > > How does one build world with ASAN ? > > > > HardenedBSD has a feature branch in its playground repo for ASAN-ified > > world. > > > > We introduced two new MK_* toggles: MK_ASAN and MK_ASAN_RECOVER. > > MK_ASAN is self-explanitory. MK_ASAN_RECOVER tells the sanitizer > > framework to let the application continue running instead of abort > > execution. > > > > Here's where the magic gets set: > > > > https://github.com/HardenedBSD/hardenedBSD-playground/blob/hardened/ > > current/asan/share/mk/bsd.prog.mk#L125-L134 > > > > Thanks, > > >=20 > I don't use HardenedBSD. Can you provide an invocation that will > demonstrate the breakage on FreeBSD head? I tried a few things, and they > all either worked, or failed with errors other than the one you showed. No worries. I've just reverted the commit in that feature branch. If I have time, I'll see about porting the ASAN work to vanilla FreeBSD. But my time is extremely limited these days. Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --gu7ci6sptypsxkle Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlqprDEACgkQaoRlj1JF bu5JjQ/+L+8YxLuF6A8521Jf1Z1MHyP/n13HmM30KPIKWIrM/9phA+9qxm6IUnWG ixOoF/RsTn07M2BkJLL/LzFoluIXiY+CFv01bI7eRu8raLugppbNsU7L4LDJlThK I3xlxfhwRhu175VAIfl5+PPxcBRKMcsu0yAkucoijKXqMVjwnyEu+EOwv1GhdNC4 y/JduSI459khEpOA9kHfXAZ/8dl9m7XLG1vgcs/Ix+m+4KDMXXb7oU/xlxc4yES5 eRRzWmWk2CAK0SQDDdCC3tTgOqZXpJT0JpvJrHXR6J1D0nEBL2ehIA/+dZKwUJqX BPYQr3vYhVL3cEINK10j/EUkTbba0kYkuGCi+XhDZqTI7flSUF24w8xqRr2SEhyk 19OaT1Zwy/nGQgKRrdyKF2mXib+m+55Noo3rF/VPLHlSJttXPQUFKyxGUYd03D5x iAWRdziSHPh2XSPebGCPEF71XRKsfM7zyfwPpE4ItpX8AaTxUZvWq/x9HZoIjXTN eYBTppg6lwoTm+UZKvyLcJ5t/oyqt6a7rEE62lZsBdWMpoyJ3/cRylfZ1KnVYjhY 2wysY1Rm7vd30lq+m/hB0K2l2DlpQjpbd9m71apgJ7x8fQc8CNHIvQ79t7R5vK1d IDozYqUHKi5fEojJHgmgL7JzD1ObWWpQoaDihcFMpWqYe1laZLo= =0VSS -----END PGP SIGNATURE----- --gu7ci6sptypsxkle--