From owner-svn-src-all@freebsd.org Wed Apr 13 09:27:51 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36184B0E1EA; Wed, 13 Apr 2016 09:27:51 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-vk0-x244.google.com (mail-vk0-x244.google.com [IPv6:2607:f8b0:400c:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EB66613E2; Wed, 13 Apr 2016 09:27:50 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-vk0-x244.google.com with SMTP id a6so5552946vkh.1; Wed, 13 Apr 2016 02:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=2QaO5vKwrimTnI0FGmDFBgBGnZIEIAh6a5A6BdhHLFg=; b=0WDjSngum8/uYOt1VkJlefpuD2iKXnnsY68AzU17VWcW2CkSJW7Obn1mbkWELYCokO xyhrRv+wTIA5/XgkterdjgzDalsTL3EBFWWbZeGESTfshquQMGbrfyoXvV17frNN4OY/ DtbkG84EJDoX+MGmT5zjMCLIDn2JQ62yxB6KTJ7GpFIffe2ngIRWRL+Ax3PKzYwkLyit UBA5XQFnArRMXn4WLLqvS/V6WPu0UTRpWaBBWRbHmPVSi5Gn9QrkW0IOAo+kQ8NYQqmI zrl8eb1k8bJf7A3FD6D1uAt4hrGtVLqTjrLhC2eheJPjM9gwwijTx6FoYI84ErcZ5a85 nJWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=2QaO5vKwrimTnI0FGmDFBgBGnZIEIAh6a5A6BdhHLFg=; b=UldiShRB4RI1J9hoYJBPIxhKoDOKxJdKzjkjC2K4npHz6SJa9SPjMnzkRK44tEq0Xk OCOFrkmqEuJd22D7iZDmyb+JyYrurH2TgwMMho+X9ddLAGOHz9I0Br70XghL2rCNn2qN MObM4fNgjkvAYgZngkeF5CvhtGiD3u1J3PcJvpI3XzL358DTa73j9iA8O7IxUZuKexZ2 ImJddFUT+6HIQ1bAVpZz94w8ciahP2Rwcny01Uro9NiqpsoSOScPqeS/hwN3wdeGeXpk FVXUCF+tnVN6TbGA1+52WrVkB6DLDghmsDCWNf/2TbusteQVnbGLsfsJb9F2GGsKxXLF xC0A== X-Gm-Message-State: AOPr4FWP+pHEmcrJgu/4doScUyLtGJ6TiPbwL5bsYjjcNjhxm/jL2QxYJgf/Kc1rsK/Lle/VkOFcEf+VFwWvYQ== MIME-Version: 1.0 X-Received: by 10.31.50.65 with SMTP id y62mr4205788vky.11.1460539670077; Wed, 13 Apr 2016 02:27:50 -0700 (PDT) Sender: sepherosa@gmail.com Received: by 10.176.64.130 with HTTP; Wed, 13 Apr 2016 02:27:49 -0700 (PDT) In-Reply-To: <570E112B.10207@selasky.org> References: <201604130920.u3D9KTVv071995@repo.freebsd.org> <570E112B.10207@selasky.org> Date: Wed, 13 Apr 2016 17:27:49 +0800 X-Google-Sender-Auth: tMsoVeEHBqCZloNQ0STFp-Gm4bQ Message-ID: Subject: Re: svn commit: r297913 - in head/sys/dev/hyperv: netvsc storvsc From: Sepherosa Ziehau To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2016 09:27:51 -0000 Yeah, I knew, but it worth a different commit :) On Wed, Apr 13, 2016 at 5:28 PM, Hans Petter Selasky wrote: > On 04/13/16 11:20, Sepherosa Ziehau wrote: >> >> bzero(sc, sizeof(hn_softc_t)); > > > Hi, > > According to: > >> >> https://svnweb.freebsd.org/base/head/sys/kern/subr_bus.c?revision=297776&view=markup#l2763 > > > It is safe to assume that the memory you get is already zero'ed. > > The additional bzero() in your attach routine seems redundant. > > --HPS -- Tomorrow Will Never Die