Date: Wed, 13 Apr 2016 17:27:49 +0800 From: Sepherosa Ziehau <sephe@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297913 - in head/sys/dev/hyperv: netvsc storvsc Message-ID: <CAMOc5czN8heWo%2BcSrbW%2Bxn-1Nn82GXmk7bKfLs74O1PZgVmOtQ@mail.gmail.com> In-Reply-To: <570E112B.10207@selasky.org> References: <201604130920.u3D9KTVv071995@repo.freebsd.org> <570E112B.10207@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yeah, I knew, but it worth a different commit :) On Wed, Apr 13, 2016 at 5:28 PM, Hans Petter Selasky <hps@selasky.org> wrote: > On 04/13/16 11:20, Sepherosa Ziehau wrote: >> >> bzero(sc, sizeof(hn_softc_t)); > > > Hi, > > According to: > >> >> https://svnweb.freebsd.org/base/head/sys/kern/subr_bus.c?revision=297776&view=markup#l2763 > > > It is safe to assume that the memory you get is already zero'ed. > > The additional bzero() in your attach routine seems redundant. > > --HPS -- Tomorrow Will Never Die
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMOc5czN8heWo%2BcSrbW%2Bxn-1Nn82GXmk7bKfLs74O1PZgVmOtQ>