From nobody Fri Jun 6 01:14:19 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bD3JF3MV9z5xC3P for ; Fri, 06 Jun 2025 01:14:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bD3JF1R7fz3jpx for ; Fri, 06 Jun 2025 01:14:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-70dd2d35449so13304867b3.3 for ; Thu, 05 Jun 2025 18:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1749172476; x=1749777276; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Hhjz7IWMlaVI8eBb3MnC4EzqBqDPxRu6uSWgl5uTi2w=; b=Km1XCmgfTaE8CYtgUpgIE0wVAP0MpngpVscdFFNEy/M2oH+nbqsjFiiLVAiAaUTbOz p8o7Xtj+YIRjmbQxVAV9EWFIsmacME0NOfzFzw0s7We94MjtLgnoavInrrmwuGUk+HHT Dpxu5q3BrILfJpmaNuPAFmDNlFOGxT/afj7ywVxDdxHLVRg/CXMYi/QyymHMW3+dnm4p 6c7CWHxBaLoCck547Co2qIe4h07apxZfj3gVrsHkbnXcr8Wac+9PDm51nY897ebuGLvH viTR2DeVZHDbJCMrg/6i6cGoJpZ8KV9hiXK1pAv+XLERALWTwC6tJZ0tmmAj7pbGEohb Bgpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749172476; x=1749777276; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hhjz7IWMlaVI8eBb3MnC4EzqBqDPxRu6uSWgl5uTi2w=; b=JF5hR6OmXQar0NUmUrKa9zpFvETi5rRsRz8FqVPZ3oMV7Gxw9HpT/x+5kigmhZCWxn KqDr8MYbD2r0InCLjUrvl+0ZqnkeKCMkgwRGaWyHZMOsWiD2E3QvCunCVYMHqeF/rvk2 UidH3T6eleR9scHGGTyu4LbFZzl7qOgHDyBc+PA8p0CMwRIk8jh80k7dShT6mUR96YzP SJ6kwakKnEWF+Wsez7Y7xnXAvINNkiLXdj97iAzRUAFrJjSjvhL81oR8mFInuZ0F0jwy ft+zxb66/Gm4rD7ll3wIBFA9SKqbgXIHAPifdAee7tAr1XiM00vZOpvBrnL5djbUVtpv X+5w== X-Forwarded-Encrypted: i=1; AJvYcCWjzWwTBo19B2UBwY3YZjwEfX8DbS7+csP9sDqEN0+Oe+UvoYuEasRDjlmGzGF5avuswi2O/DrUeRMb5DRItp8hi0HSSg==@freebsd.org X-Gm-Message-State: AOJu0YxtH1JdClRNB5pKGzkwkE6icksEZOc2E3tEb75MNF209isUSb4B O9iuXzKdXjaeYiQK/T6tHzRy/ZbaGuVw6mFXVmlCBDl3ZLiEZ75Bvo8vxsLPmTSuDUMvqLfuEw8 gN8MjlOcdGjcLmx+TvBLcJpzpK52yMgDGitwFM+Xy8A== X-Gm-Gg: ASbGncs7qQqSwow45V5lGMtG1LE8lhptjnByh1YnzYb6ikPRIUHA+iI44urXA1j5m68 vDV+i4uQ5xpADNWioOFGICR0kAASj5oPipx/NSZHmqUA9nYPtedhrfCYPUmpcil79FSLGQKufh4 GHJpny34vK3epydZTY5JCK8fMvktGhJn4yHqJFc9it/gJoZuJyoWubLIoPGLlZa47pDA== X-Google-Smtp-Source: AGHT+IFZrJwlIifjx56F+RjBTc9kp7RHSqC3eU1F/zm+asOzJpCq22bccCPfRn8+AJvfs0QfxU/h94LotCl74fCw6MA= X-Received: by 2002:a05:690c:6302:b0:70e:7a67:b4b5 with SMTP id 00721157ae682-710f76a56b4mr23197227b3.22.1749172475989; Thu, 05 Jun 2025 18:14:35 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202506052106.555L6XBV089396@gitrepo.freebsd.org> <53d9ce10-191c-4edf-85d1-41b3162aefa4@freebsd.org> <371a7bf2-61ee-4528-9aec-846601973b78@freebsd.org> In-Reply-To: <371a7bf2-61ee-4528-9aec-846601973b78@freebsd.org> From: Warner Losh Date: Thu, 5 Jun 2025 19:14:19 -0600 X-Gm-Features: AX0GCFvJc3Yaf2BOJDDHeSMRFt9r7sG7LX6sf3bUU_jwv9nJxwUh3yPn5bK5jTc Message-ID: Subject: Re: git: 60159a98a837 - main - nvme: Move opcode and status code tables from base CAM to nvme_util.c To: Charlie Li Cc: John Baldwin , src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000001520760636dcf401" X-Rspamd-Queue-Id: 4bD3JF1R7fz3jpx X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] --0000000000001520760636dcf401 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 5, 2025, 6:46=E2=80=AFPM Charlie Li wrote= : > John Baldwin wrote: > > On 6/5/25 19:29, Charlie Li wrote: > >> doesn't appear to be making it in nvme_all.h as the > >> build complains about missing nvme_opcode_sbuf() in nvme_all.c. > > > > Are you getting a link error or a compile error? I built this locally > > several times > > today to test various combinations (kernels with and without either CAM > > or nvme and > > loading nvme.ko in kernels without to make sure it worked). I also > > built GENERIC > > prior to pushing and it built fine. > > > Compile error in buildworld. > In libcam? Warner > Sigh, so from ci.freebsd.org, it appears to be userland that is choking > > (libcam) > > rather than the kernel. I'll fix shortly (mostly it just means removin= g > > the > > #ifdef _KERNEL). > > > > -- > Charlie Li > ...nope, still don't have an exit line. > --0000000000001520760636dcf401 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jun 5, 2025, 6:46=E2=80= =AFPM Charlie Li <vishwin@freebsd= .org> wrote:
John Baldwin wr= ote:
> On 6/5/25 19:29, Charlie Li wrote:
>> <sys/dev/nvme.h> doesn't appear to be making it in nvme_= all.h as the
>> build complains about missing nvme_opcode_sbuf() in nvme_all.c. >
> Are you getting a link error or a compile error?=C2=A0 I built this lo= cally
> several times
> today to test various combinations (kernels with and without either CA= M
> or nvme and
> loading nvme.ko in kernels without to make sure it worked).=C2=A0 I al= so
> built GENERIC
> prior to pushing and it built fine.
>
Compile error in buildworld.
=
In libcam?

Warner

> Sigh, so from ci.freebsd.org, it appears to be userland tha= t is choking
> (libcam)
> rather than the kernel.=C2=A0 I'll fix shortly (mostly it just mea= ns removing
> the
> #ifdef _KERNEL).
>

--
Charlie Li
...nope, still don't have an exit line.
--0000000000001520760636dcf401--