From owner-freebsd-current Fri Mar 24 14:24:56 2000 Delivered-To: freebsd-current@freebsd.org Received: from 1Cust199.tnt1.waldorf.md.da.uu.net (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 7196B37C0E5; Fri, 24 Mar 2000 14:24:45 -0800 (PST) (envelope-from green@FreeBSD.org) Date: Fri, 24 Mar 2000 17:13:55 -0500 (EST) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Steve Kiernan Cc: freebsd-current@freebsd.org Subject: Re: breakage still in sys/systm.h In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 24 Mar 2000, Steve Kiernan wrote: > The definitions of major() and minor() in sys/systm.h break usage of the > header. Since sys/types.h defines major() and minor() as macros which > compute the major and minor numbers, this creates an order dependency on > sys/systm.h and sys/types.h. Is this not a bad thing? The sys/types.h header is meant to be included in userland code; the sys/systm.h header is not to be included from outside of kernel code. What possible reason would you have for systm.h in userland code? > -- > Stephen Kiernan > stevek@tislabs.com > NAI Labs, A Division of Network Associates, Inc. -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message