Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 14 Mar 2021 09:09:52 GMT
From:      Ryan Moeller <freqlabs@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 4e535a1ba72e - stable/13 - lib/flua/libjail: Allow empty params table
Message-ID:  <202103140909.12E99qPr078438@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by freqlabs:

URL: https://cgit.FreeBSD.org/src/commit/?id=4e535a1ba72e1f751f9cf869ab8c9d06514d6c59

commit 4e535a1ba72e1f751f9cf869ab8c9d06514d6c59
Author:     Ryan Moeller <freqlabs@FreeBSD.org>
AuthorDate: 2021-02-25 05:16:52 +0000
Commit:     Ryan Moeller <freqlabs@FreeBSD.org>
CommitDate: 2021-03-14 08:09:20 +0000

    lib/flua/libjail: Allow empty params table
    
    The name or jid always gets added to the params, and that's enough to
    avoid allocating a 0 length params array.
    
    Reported by:    kevans
    Reviewed by:    kevans
    Differential Revision:  https://reviews.freebsd.org/D28778
    
    (cherry picked from commit e175b519a6fb83889fb3ca679b73d11ea5bea7ad)
---
 lib/flua/libjail/lua_jail.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/flua/libjail/lua_jail.c b/lib/flua/libjail/lua_jail.c
index 9981fd5421c6..b66c60b43bc8 100644
--- a/lib/flua/libjail/lua_jail.c
+++ b/lib/flua/libjail/lua_jail.c
@@ -113,7 +113,6 @@ l_getparams(lua_State *L)
 	    "expected a jail name (string) or id (integer)");
 	luaL_checktype(L, 2, LUA_TTABLE);
 	params_count = 1 + lua_rawlen(L, 2);
-	luaL_argcheck(L, params_count > 1, 2, "expected #params > 0");
 	flags = luaL_optinteger(L, 3, 0);
 
 	params = malloc(params_count * sizeof(struct jailparam));
@@ -236,7 +235,6 @@ l_setparams(lua_State *L)
 	lua_pushnil(L);
 	for (params_count = 1; lua_next(L, 2) != 0; ++params_count)
 		lua_pop(L, 1);
-	luaL_argcheck(L, params_count > 1, 2, "expected #params > 0");
 
 	flags = luaL_optinteger(L, 3, 0);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103140909.12E99qPr078438>