From owner-freebsd-arm@freebsd.org Wed Jan 27 19:14:46 2016 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCE36A6F0C2 for ; Wed, 27 Jan 2016 19:14:45 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-lb0-x22a.google.com (mail-lb0-x22a.google.com [IPv6:2a00:1450:4010:c04::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 60088172C for ; Wed, 27 Jan 2016 19:14:45 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by mail-lb0-x22a.google.com with SMTP id dx2so11001616lbd.3 for ; Wed, 27 Jan 2016 11:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=IB8NEMfbkpKIaCQnIYLIjxV25JoGoOp6BOyQnI8WjLE=; b=R8jUylnKqj+9uQTeni+WLlvgh4IrxwecYKqBqqDBl3AxzTwCNq2JW7lkI4EwJlyIv0 mMWI296XNFElSgh90tkCSNI4Ovjh0F3n+aIJ5DKUAqZEgf73d26V5IYV6kuOd9H15Q+k MIDn0nGukOtHXCGKCQI6RdvwdJiufHoxaep7jMwQEclCoemHAT0TnAgGfgdkXuFthC6Q rULaTvAcksJaP93DUMWg1yoCapi42Bg0W4o0VI+2AOzmYz8W4TjCUQJFIXkMQC75+dbE aGekP6DYRxirYK8ven8CykmoSJDjdwfncfFBkuoVSbC959y6ybFdnZVk41HN/eeUCK26 7krQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=IB8NEMfbkpKIaCQnIYLIjxV25JoGoOp6BOyQnI8WjLE=; b=Mm0IqT1+D0y+H7qbj5GBjkxSTlgzV2w0jg1CetYegXj6C0hupKgZJ5LIga1DYIUA+T F8dlYYdIY8GhIKSikBRoqeyCF4zfMdx5wbo2hb7UXu7x4ExyjS98BDVzo7cKRmZEgRlE dLgJXMQ3iZANYDFBCaD1kRKD8RNnyShywJLzBNm8pR1gAePFXEAzwFvCy0eRvIZQck0F iuzsM3WTJw8mZEjKFfqSdAeUORrqaZ6PIXPp3LKKHMZ8vRu1ti2ZJtdCLEleFhntaKyC mjv7eNaWxcrBl+GVRQvz0Xo5U6PtUfrtIr5n9nBHXImMnGjpPIyGMqIbx0FtRa3pPOXm VZMw== X-Gm-Message-State: AG10YORXPqLJ8Cd/OebMo5pKnl0bzBM/UxYnggl8LduedcDttNFTM9sxisUq8rteahF7NgPl9RCBJ6RiCvoXOg== X-Received: by 10.112.209.99 with SMTP id ml3mr11218222lbc.26.1453922083428; Wed, 27 Jan 2016 11:14:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.198.7 with HTTP; Wed, 27 Jan 2016 11:14:23 -0800 (PST) In-Reply-To: <20160127184822.GE74231@kib.kiev.ua> References: <2587742.rOiGAYXjN1@ralph.baldwin.cx> <20160127181426.GA48838@ci0.org> <20160127184822.GE74231@kib.kiev.ua> From: Zbigniew Bodek Date: Wed, 27 Jan 2016 20:14:23 +0100 Message-ID: Subject: Re: SCHED_ULE race condition, fix proposal To: Konstantin Belousov Cc: Olivier Houchard , arm64-dev , "freebsd-arm@freebsd.org" , hackers@freebsd.org, John Baldwin Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 19:14:46 -0000 2016-01-27 19:48 GMT+01:00 Konstantin Belousov : > On Wed, Jan 27, 2016 at 07:14:26PM +0100, Olivier Houchard wrote: > > Hi, > > > > I may be reading the arm64 code wrong, but shouldn't : > > ldr x0, =_C_LABEL(blocked_lock) > > ldr x2, [x0] > > > > be just: > > ldr x2, =_C_LABEL(blocked_lock) > > You are right, I believe. > Hah! Great catch! :-) Best regards zbb