From nobody Thu May 11 17:08:02 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QHJHn08tcz49V13; Thu, 11 May 2023 17:08:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QHJHm6SVNz3GWB; Thu, 11 May 2023 17:08:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683824884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HYVmS7tmlHBc+Q0D+y6RzbeJFVFL5l3vHMpevLJkKrs=; b=sLzMXDnJnnooL5ypemPh4XtXuN3nSsLXATljqbU9hDTJEHxoYkfJJh0sFA1vobtZ9JYD0K xRcVRt3RLpI3ixoMSa+Bc+Yf6m3T60XDGStcN3n5o7/fus+S4xrBcCZsVTjZAx/qaMGDgt OyA+TETHbKCg5BAG8fm0CVeRSwKEdsEJynF9YdgLVxbWt34hLF3C1nKznCFtXkaZoVku8w I6nL1wuw4+rkWx1yXt3x1tqVKjB08kgBF84v599tVvZcbOTEZkn18rJTCDblRf4VuG1SzR 6CM1/QtKjQPQzuv3B1wBNGwnqD43kdEoZw8v/S/JsPlaKZqmADhdnrjrEtQoHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683824884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HYVmS7tmlHBc+Q0D+y6RzbeJFVFL5l3vHMpevLJkKrs=; b=MK/E+7c3NwUUGnFyJn2zb5Vm3/8m0iKdlh9zYs/HkI5M2uCsiScscpHRVuFrBoBC9W92fP 34lVON+0deXkPRI6dMw4c+ZBvW+9iGAkMlS/aEioABzm24P3vGMm3MtPk64RZEWkOgaiv/ OaC6EihYSzlHx2cYjr3MCDUKfwv5MQdw9qkjZH50R5+L5GgK6M8Sxe2gUwqbJ+p74mh8D5 zooGwsm8eBX6LPI9g5WoHany0yTqJTe8U2iHYmyk6Si4ie/yIn0C77V4nBTyyGZlUuteWs GdAvUtMA5iinV1ZzCH1SwVjbeWsX7oMXiECJocuXdu45m2/4Za9ltF/Yfz4hVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683824884; a=rsa-sha256; cv=none; b=vivMApC1FWBM6gIiE0/Azc6c7xVxSreVw8d8F+/2+ShngCxJB/APpTDicKH7PtM8k/9/pD 62720WnHlle8mRU5snaIx5fAb0HX5Jz3Qjyjvsn3ROdn7j7JI81phDx3hh8k+o0RKBmzgR 4S5YXkgNTpHzCLgCBQ2ThDcSJewJZmxdfA0AkkHE02YXEEaMzrqtqkuQ7hy8dpJmQsE7jV IK3crUWFe45ZgHOIH4zy/KP4g2O6BhBjCN5XmugPpBqKUCR5lwc+OdtKcKR+H/jHkPias+ H1XMjnIlDJjwe8efkloW/QiHU2fE+YgjlWtEy877BoBvVyMXs+nwia5gVvmH2A== Received: from [IPV6:2601:648:8680:16b0:68c6:c580:9c72:9097] (unknown [IPv6:2601:648:8680:16b0:68c6:c580:9c72:9097]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QHJHm0G9rzNCs; Thu, 11 May 2023 17:08:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Thu, 11 May 2023 10:08:02 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: git: 74192f9b2d24 - main - ktls_test: specify OpenSSL 1.1 API Content-Language: en-US To: Enji Cooper , Ed Maste Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Pierre Pronchery References: <202305111431.34BEVrtp073189@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 5/11/23 7:59 AM, Enji Cooper wrote: > >> On May 11, 2023, at 07:31, Ed Maste wrote: >> >> The branch main has been updated by emaste: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=74192f9b2d240edbd72215b8ee770485502ce8ee >> >> commit 74192f9b2d240edbd72215b8ee770485502ce8ee >> Author: Pierre Pronchery >> AuthorDate: 2023-05-11 03:49:44 +0000 >> Commit: Ed Maste >> CommitDate: 2023-05-11 14:30:51 +0000 >> >> ktls_test: specify OpenSSL 1.1 API >> >> Reviewed by: emaste >> Sponsored by: The FreeBSD Foundation >> --- >> tests/sys/kern/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/sys/kern/Makefile b/tests/sys/kern/Makefile >> index dec2384bc80b..931ec507885a 100644 >> --- a/tests/sys/kern/Makefile >> +++ b/tests/sys/kern/Makefile >> @@ -70,6 +70,7 @@ LIBADD.sys_getrandom+= pthread >> LIBADD.ptrace_test+= pthread >> LIBADD.unix_seqpacket_test+= pthread >> LIBADD.kcov+= pthread >> +CFLAGS.ktls_test+= -DOPENSSL_API_COMPAT=0x10100000L >> LIBADD.ktls_test+= crypto util >> LIBADD.sendfile_helper+= pthread >> LIBADD.fdgrowtable_test+= util pthread kvm procstat > > Would there be any objections to me fixing these issues before we freeze for 14.0-RELEASE? Also, are the issues being tracked somewhere in a wiki page or bugzilla? I think we are happy to have them fixed, just in parallel to not hold up the import? I planned to look at some of these during BSDCan next week (in particular ktls_test and cryptocheck at least since I wrote the bulk of those). They really should just be using EVP already, but maybe they still use the HMAC() wrapper. -- John Baldwin