Date: Thu, 11 May 2023 10:08:02 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Enji Cooper <yaneurabeya@gmail.com>, Ed Maste <emaste@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Pierre Pronchery <pierre@freebsdfoundation.org> Subject: Re: git: 74192f9b2d24 - main - ktls_test: specify OpenSSL 1.1 API Message-ID: <f0eadf4a-2b63-bbda-ab6a-590f550c3fed@FreeBSD.org> In-Reply-To: <CA43A25C-82BE-492F-BD1B-3F1E84707A87@gmail.com> References: <202305111431.34BEVrtp073189@gitrepo.freebsd.org> <CA43A25C-82BE-492F-BD1B-3F1E84707A87@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/11/23 7:59 AM, Enji Cooper wrote: > >> On May 11, 2023, at 07:31, Ed Maste <emaste@freebsd.org> wrote: >> >> The branch main has been updated by emaste: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=74192f9b2d240edbd72215b8ee770485502ce8ee >> >> commit 74192f9b2d240edbd72215b8ee770485502ce8ee >> Author: Pierre Pronchery <pierre@freebsdfoundation.org> >> AuthorDate: 2023-05-11 03:49:44 +0000 >> Commit: Ed Maste <emaste@FreeBSD.org> >> CommitDate: 2023-05-11 14:30:51 +0000 >> >> ktls_test: specify OpenSSL 1.1 API >> >> Reviewed by: emaste >> Sponsored by: The FreeBSD Foundation >> --- >> tests/sys/kern/Makefile | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/sys/kern/Makefile b/tests/sys/kern/Makefile >> index dec2384bc80b..931ec507885a 100644 >> --- a/tests/sys/kern/Makefile >> +++ b/tests/sys/kern/Makefile >> @@ -70,6 +70,7 @@ LIBADD.sys_getrandom+= pthread >> LIBADD.ptrace_test+= pthread >> LIBADD.unix_seqpacket_test+= pthread >> LIBADD.kcov+= pthread >> +CFLAGS.ktls_test+= -DOPENSSL_API_COMPAT=0x10100000L >> LIBADD.ktls_test+= crypto util >> LIBADD.sendfile_helper+= pthread >> LIBADD.fdgrowtable_test+= util pthread kvm procstat > > Would there be any objections to me fixing these issues before we freeze for 14.0-RELEASE? Also, are the issues being tracked somewhere in a wiki page or bugzilla? I think we are happy to have them fixed, just in parallel to not hold up the import? I planned to look at some of these during BSDCan next week (in particular ktls_test and cryptocheck at least since I wrote the bulk of those). They really should just be using EVP already, but maybe they still use the HMAC() wrapper. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f0eadf4a-2b63-bbda-ab6a-590f550c3fed>