From owner-cvs-all Sun Oct 3 5: 3:53 1999 Delivered-To: cvs-all@freebsd.org Received: from cs0.catv.ne.jp (cs0.catv.ne.jp [202.232.171.20]) by hub.freebsd.org (Postfix) with ESMTP id 8258A14F93; Sun, 3 Oct 1999 05:03:44 -0700 (PDT) (envelope-from nyan@dd.catv.ne.jp) Received: from localhost by cs0.catv.ne.jp (8.9.1/3.7W) id UAA21866; Sun, 3 Oct 1999 20:59:32 +0900 (JST) To: bde@zeta.org.au Cc: imp@village.org, winter@jurai.net, kato@FreeBSD.org, nyan@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Cc: FreeBSD98-hackers@jp.freebsd.org Subject: Re: cvs commit: src/sys/conf files src/sys/i386/conf files.i386 In-Reply-To: References: <199909270628.AAA08033@harmony.village.org> From: Takahashi Yoshihiro X-Mailer: Mew version 1.94 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <19991003210001T.nyan@dd.catv.ne.jp> Date: Sun, 03 Oct 1999 21:00:01 +0900 (JST) X-Dispatcher: imput version 990905(IM130) Lines: 20 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In article Bruce Evans writes: > Indirect addressing would use the current bus space functions with offset 0, > e.g., bus_space_read_1(sc->tag, sc->line_status_port, 0). > sc->line_status_port can still be cached in a register variable, so we > lose mainly in MEMIO cases that could have used > bus_space_read_1(tag, iobase, com_lsr) and where the bus space function > isn't slowed down by more tests. Does your method assume bus_space_handle_t to be u_int? I think that we should not assume like this. and, there is not the much meaning that uses bus_space in your method. Certainly, Warner's method is inferior performance to your method. But, I think that it is not a big problem, because it is a very trivial thing. --- Takahashi Yoshihiro / nyan@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message