From owner-freebsd-wireless@freebsd.org Sun Jan 24 22:01:07 2016 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E34EB7016 for ; Sun, 24 Jan 2016 22:01:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x229.google.com (mail-ig0-x229.google.com [IPv6:2607:f8b0:4001:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AF53720C for ; Sun, 24 Jan 2016 22:01:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x229.google.com with SMTP id z14so23731207igp.1 for ; Sun, 24 Jan 2016 14:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=aagu4sqyVToks9GgyYt0aHcWDD4xL06KSOzF8WZKB3s=; b=m0steyUEU8uOBliFpyQhfxgGElC8u4vo1x/a1mkfwPj0mc5wERc2bApjGp3O2kmeeS 6mWs4cLdQ8W54CiABUue1V5achd3Eh6Xh/A4Sxgck8Puvs3xxf8p661rqdKZFtJOTJi2 D0k4OZIAyTo1ynG/ITe6bLp7eBAi/j+N3J81Kylmbt5DPactIM9bEK9bVEYL9cCPumeQ 7rbUitSbQUHm1ClHRQ/ygdLq2JU5q3QHltFskdzh8N88xdCI26Isq4Nd9fbWOthB8818 /bW1bO9/RD5N6FgZTk8liX1A1M0xLDDl58QgFoTe05lR2vH6Zi/PvbOUeMgwFK7hbDX9 JXgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=aagu4sqyVToks9GgyYt0aHcWDD4xL06KSOzF8WZKB3s=; b=FSMY2dMPUvNuAH/YW6UQ3esdK1zivpNlQQ3b3H5Kb7rZ0Icburr5Q6YdJGwlGgMKUz 4KKl6E23+BxP2E/NKosITpWRznE/l7f3Tc6CuNiTDlzEdpvc8NI2KfN7a81lTvonBrak Y7lslG2/+CvX+GPfpwbc0K5stxz2knprtOgJhMzzYhwJWvaBvMq1ljko/sNddPKZ0060 j+JrwGiticNwJ2N+NYmGjTddNKH66MIhKuhQM9P4+9Xk5x7eI9FBLgGDwxOCUGeoIYHZ UC+ebuYP7qFIIwXfWp6+2J1IaLJVn02Qtkd5ev8WB9NQWxbnsEskydHmDy9rfch2G3/e 6Y0w== X-Gm-Message-State: AG10YOTpujFUvrH97yWSnlZog4FcfCUTfR3xOL7cxQBF9sNvKIsFDoNs9g0fTeTNRksrttOtoUSVOeuYljWrzg== MIME-Version: 1.0 X-Received: by 10.50.137.41 with SMTP id qf9mr13478059igb.22.1453672865939; Sun, 24 Jan 2016 14:01:05 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.121.16 with HTTP; Sun, 24 Jan 2016 14:01:05 -0800 (PST) In-Reply-To: References: Date: Sun, 24 Jan 2016 14:01:05 -0800 X-Google-Sender-Auth: vBTN1bBXl5YV258Ld_N7uaFDkHU Message-ID: Subject: Re: net80211: why we ca'nt use the net80211 taskqueue for everything From: Adrian Chadd To: Andriy Voskoboinyk Cc: "freebsd-wireless@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2016 22:01:07 -0000 On 24 January 2016 at 13:40, Andriy Voskoboinyk wrote: > Sun, 24 Jan 2016 22:22:44 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd > : > > Hi, > > is it actual for wpi(4) / iwn(4) ? If you defer things like tx, calibration, etc then yeah - you'll see things like software generated probe request frames and such be deferred. (I tried this with ath(4) about 5 years ago - hit the same issue. So I've put it off until the scan code is "fixed".) -adrian > > >> hi, >> >> andriy has a few reviews out that tidy up some things, which I'd reply >> to, but .. reviews is offline. So, here's the 30 second version: >> >> * the net80211 taskqueue runs the software scan engine, and the >> software scan engine currently sleeps whilst it's running. >> >> This means that if you put newstate, deferred transmit, etc into the >> net80211 taskqueue, then it just won't run during scan. >> >> The net80211 software scan thing should be modified to not sleep >> whilst it's waiting for scan results and instead just kick off another >> timer event to finish that part of the loop. Then yes, we can just >> migrate * to the net80211 task queue and use it for all serialisation >> of a wifi driver. >> >> (And yes, I'd like to see that done ASAP..) >> >> Thanks, >> >> >> -adrian