From owner-cvs-all Thu Oct 3 2: 5:17 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 34CA637B401; Thu, 3 Oct 2002 02:05:16 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id E315743E42; Thu, 3 Oct 2002 02:05:14 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id TAA31718; Thu, 3 Oct 2002 19:05:12 +1000 Date: Thu, 3 Oct 2002 19:14:51 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Juli Mallett Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/kern kern_synch.c In-Reply-To: <200210030409.g93490uo016016@freefall.freebsd.org> Message-ID: <20021003190351.U3114-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 2 Oct 2002, Juli Mallett wrote: > jmallett 2002/10/02 21:09:00 PDT > > Modified files: > sys/kern kern_synch.c > Log: > XXX Add a check for p->p_limit being NULL before dereferencing it. This is > totally bogus but will hide the occurances of access of 0xbc(NULL) which > people have run into lately. This is not a proper fix, just a bandaid, until > the cause of this happening is tracked down and fixed. > > Reviewed by: rwatson > > Revision Changes Path > 1.201 +6 -1 src/sys/kern/kern_synch.c The PRS_ZOMBIE check was supposed to prevent the pointer being NULL. I think this check is bogus too, and have removed it. The corresponding SZOMB check is not present in Lite2. It doesn't make sense for zombies to switch context. BTW, the Lite2 version of mi_switch() is depressingly cleaner than the current version, but not as clean as the FreeBSD-1 version which is so clean that it didn't exist. (The MI parts of switch() in Lite2 were just timestamp stuff including enforcing the rlimit, and bumping the counter. FreeBSD-1 didn't even have the timestamp stuff, so there was one MI thing for switch() to do (just bumping the counter), and that was so simple that it was done in MD code.). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message