From owner-svn-src-head@freebsd.org Sun Jan 8 20:49:41 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 96758CA5E99; Sun, 8 Jan 2017 20:49:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 65F1D1CB0; Sun, 8 Jan 2017 20:49:41 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id 204so2852032pge.2; Sun, 08 Jan 2017 12:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8SwQ1oodX8tdfSxvmS1v6ikbbRXyf00Y9UWMNDtkcUo=; b=udUN1qs9bpW2SXBDDNzq2wA/CMo0WYNLaslg7ymLKlgy1Q2io4+JCXOCAsFUxFyAAb Wf+iXlZacc+2NTIVsprYs2ALT2NHo10zW84PCtJLqDz3JQp+B4FH5FDieqVQ+PITB3hu PPYMsc9QDox7QEJw2CeuTejZH2N1ss5be8BmUxFRdwiJpTlOMT9OvSWi8vTbeZ6i6ULG BR8oIo3jNsOpMJbLLjwYBxnwOx3jXTvlna91E5SEFkmbt2HdLPAycjsbzElNVEpInrly wgQBpkgIEbfuUcLsgo0PE9nUEwqL/ajWix154ygMuPttw30EmmxHO9DX1QskrMAUmnWd xySA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=8SwQ1oodX8tdfSxvmS1v6ikbbRXyf00Y9UWMNDtkcUo=; b=XcbDZJttVhyCDzbb1axI3HuefPoc92DaNQnMimlxGlb2G85qfEuiNMBrqglyCeWjxG nNiuJwbStdFLJF5sdDeBPX8FLfVlernLZ9xSXxBH4MtkPbQyd3e0iyhj5MVXF/w+kCIK KUBdQrA0eqBRa+zU9XTYX/KpziBpWnxmKfopdYNm7BtDKGziw6NelYBLzgnpDdgbDFQQ jShgb11U3KKO8rk1+KoaFQqlU+NOrsGa0rAAkYOwJn6vdkK5cHbloZp2aerzZWD7NlVH hNPVEeU8EXJ32bAfux6t9/2Qb4MoOgVWeuzmNM4nR9/U1oCwALjNuM5dzKDr7T1UqEgR W9Rg== X-Gm-Message-State: AIkVDXJrftsikEQNHjmlIbiRxwpK9qo7K2mlzaAbKL0WcMyWKZJPFY6iFy0BU50hHMos7w== X-Received: by 10.84.195.1 with SMTP id i1mr186516356pld.84.1483908580798; Sun, 08 Jan 2017 12:49:40 -0800 (PST) Received: from raichu ([2604:4080:1102:0:ca60:ff:fe9d:3963]) by smtp.gmail.com with ESMTPSA id q145sm173280216pfq.22.2017.01.08.12.49.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jan 2017 12:49:40 -0800 (PST) Sender: Mark Johnston Date: Sun, 8 Jan 2017 12:49:38 -0800 From: Mark Johnston To: George Neville-Neil Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311225 - head/sys/netinet Message-ID: <20170108204938.GC34440@raichu> References: <201701040219.v042JDEk026544@repo.freebsd.org> <20170104182630.GA26522@wkstn-mjohnston.west.isilon.com> <4C01D080-64D9-4862-AFD5-42CC49B5CC0B@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2017 20:49:41 -0000 On Sat, Jan 07, 2017 at 02:31:28PM -0500, George Neville-Neil wrote: > > > On 7 Jan 2017, at 14:23, George Neville-Neil wrote: > > > On 4 Jan 2017, at 13:26, Mark Johnston wrote: > > > >> On Wed, Jan 04, 2017 at 02:19:13AM +0000, George V. Neville-Neil > >> wrote: > >>> Author: gnn > >>> Date: Wed Jan 4 02:19:13 2017 > >>> New Revision: 311225 > >>> URL: https://svnweb.freebsd.org/changeset/base/311225 > >>> > >>> Log: > >>> Fix DTrace TCP tracepoints to not use mtod() as it is both > >>> unnecessary and > >>> dangerous. Those wanting data from an mbuf should use DTrace > >>> itself to get > >>> the data. > >> > >> I think you also need to update the types in in_kdtrace.c, and add a > >> translator for struct mbuf * to ipinfo_t. > > > > Fair points. > > > > Actually, following up to myself, this does not need to be done just > yet. The pkt_info stuff is currently always NULL. I'm working on a > copyoutmbuf() subroutine that will make all of this much cleaner. The pkt_info stuff is unrelated to this - ipinfo_t is the third argument to the tcp probes. The translator which expects a pointer to the IP header is now getting a pointer to an mbuf, so this change effectively breaks scripts that use args[2] in a tcp:::send or tcp:::receive probe (among others).