From owner-cvs-sys Fri Mar 7 05:08:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA09773 for cvs-sys-outgoing; Fri, 7 Mar 1997 05:08:22 -0800 (PST) Received: from genesis.atrad.adelaide.edu.au (genesis.atrad.adelaide.edu.au [129.127.96.120]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA09767; Fri, 7 Mar 1997 05:08:10 -0800 (PST) Received: (from msmith@localhost) by genesis.atrad.adelaide.edu.au (8.8.5/8.7.3) id XAA22280; Fri, 7 Mar 1997 23:37:27 +1030 (CST) From: Michael Smith Message-Id: <199703071307.XAA22280@genesis.atrad.adelaide.edu.au> Subject: Re: cvs commit: src/sys/ufs/mfs mfs_vfsops.c In-Reply-To: <199703070942.UAA10031@godzilla.zeta.org.au> from Bruce Evans at "Mar 7, 97 08:42:40 pm" To: bde@zeta.org.au (Bruce Evans) Date: Fri, 7 Mar 1997 23:37:27 +1030 (CST) Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, joerg@freefall.freebsd.org X-Mailer: ELM [version 2.4ME+ PL28 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Bruce Evans stands accused of saying: > > Branch: sys/ufs/mfs RELENG_2_2 > > Modified: sys/ufs/mfs mfs_vfsops.c > > Log: > > YAMFC (rev 1.27: supply the mount point when getting a vnode) > > I don't trust this change. Maybe something uses vp->v_mount == NULL > to give special behaviour for mfs. I spent a long time looking at this. I asked in several fora a number of times. I received one answer (thankyou Sean). > Looking for tests of vp->v_mount, I found that cluster_write() begins > with a usless test of vp->v_mount. The next line indirects through > vp->v_mount unconditionally. This was my conclusion; there are not enough tests for v_mount being NULL for it to be even vaguely sensible. In particular, the crash which instigated my looking proved that v_mount being NULL is not adequately handled. > Bruce > -- ]] Mike Smith, Software Engineer msmith@gsoft.com.au [[ ]] Genesis Software genesis@gsoft.com.au [[ ]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[ ]] realtime instrument control. (ph) +61-8-8267-3493 [[ ]] Unix hardware collector. "Where are your PEZ?" The Tick [[