Date: Fri, 7 Mar 1997 23:37:27 +1030 (CST) From: Michael Smith <msmith@atrad.adelaide.edu.au> To: bde@zeta.org.au (Bruce Evans) Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, joerg@freefall.freebsd.org Subject: Re: cvs commit: src/sys/ufs/mfs mfs_vfsops.c Message-ID: <199703071307.XAA22280@genesis.atrad.adelaide.edu.au> In-Reply-To: <199703070942.UAA10031@godzilla.zeta.org.au> from Bruce Evans at "Mar 7, 97 08:42:40 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans stands accused of saying: > > Branch: sys/ufs/mfs RELENG_2_2 > > Modified: sys/ufs/mfs mfs_vfsops.c > > Log: > > YAMFC (rev 1.27: supply the mount point when getting a vnode) > > I don't trust this change. Maybe something uses vp->v_mount == NULL > to give special behaviour for mfs. I spent a long time looking at this. I asked in several fora a number of times. I received one answer (thankyou Sean). > Looking for tests of vp->v_mount, I found that cluster_write() begins > with a usless test of vp->v_mount. The next line indirects through > vp->v_mount unconditionally. This was my conclusion; there are not enough tests for v_mount being NULL for it to be even vaguely sensible. In particular, the crash which instigated my looking proved that v_mount being NULL is not adequately handled. > Bruce > -- ]] Mike Smith, Software Engineer msmith@gsoft.com.au [[ ]] Genesis Software genesis@gsoft.com.au [[ ]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[ ]] realtime instrument control. (ph) +61-8-8267-3493 [[ ]] Unix hardware collector. "Where are your PEZ?" The Tick [[
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703071307.XAA22280>