Date: Fri, 18 Sep 1998 14:12:23 -0600 (MDT) From: "Kenneth D. Merry" <ken@plutotech.com> To: eivind@yes.no (Eivind Eklund) Cc: imp@village.org, ken@plutotech.com, scsi@FreeBSD.ORG, gibbs@pluto.plutotech.com Subject: Re: Fixing LINT Message-ID: <199809182012.OAA11933@panzer.plutotech.com> In-Reply-To: <19980918213533.18854@follo.net> from Eivind Eklund at "Sep 18, 98 09:35:33 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Eivind Eklund wrote... > On Fri, Sep 18, 1998 at 01:25:54PM -0600, Warner Losh wrote: > > In message <19980918194533.52865@follo.net> Eivind Eklund writes: > > : It doesn't link, either. Same reason. > > > > What are you talking about? It links and works fine for me. I've > > been using it to access my cdrom changer for a few weeks. The file > > that is commented out in sys/i386/conf/files.i386 is the OLD aha > > driver. The new one is in both the sys/conf/files and > > sys/i386/conf/files.i386 files. What is missing for you? > > That LINT compiles and link, as it is supposed to do at all times. At > least bde and I use it as a tool for doing global kernel checks; more > people should (after any large-scale change, LINT should compile with > no new warnings). > > However, after looking some more at this, I found (about 1 minute > before I got your mail :-) that the problem for aha is that the wrong > aha line is in LINT, and for adv that it has non-compilable code inside > #ifdef DIAGNOSTIC. > > I've copied the correct aha line over, and commented out adv from LINT > for the time being. New diffs are: [ ... ] > @@ -1709,9 +1710,9 @@ > # DPT options > options DPT_VERIFY_HINTR > options DPT_RESTRICTED_FREELIST > -options DPT_MEASURE_PERFORMANCE > +#!CAM# options DPT_MEASURE_PERFORMANCE > options DPT_FREELIST_IS_STACK > -options DPT_HANDLE_TIMEOUTS > +#!CAM# options DPT_HANDLE_TIMEOUTS [ ... ] > Any protests this time around? (I can't easily fix the adv driver, as > it is mumbling about missing symbols that I have no idea where have > come from or gone to). That will probably work. I still think the "#!CAM#" stuff is annoying, but if you insist... Justin can uncomment the adv driver when he checks in a fix. (I think he's got some other, unrelated fixes in the works for that driver.) Ken -- Kenneth Merry ken@plutotech.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199809182012.OAA11933>