From owner-p4-projects@FreeBSD.ORG  Tue Jan  2 17:35:52 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4F34A16A416; Tue,  2 Jan 2007 17:35:52 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2778516A403;
	Tue,  2 Jan 2007 17:35:52 +0000 (UTC)
	(envelope-from doginou@dong.ci0.org)
Received: from dong.ci0.org (cognet.ci0.org [80.65.224.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 7029A13C46C;
	Tue,  2 Jan 2007 17:35:51 +0000 (UTC)
	(envelope-from doginou@dong.ci0.org)
Received: from dong.ci0.org (localhost.ci0.org [127.0.0.1])
	by dong.ci0.org (8.13.7/8.13.4) with ESMTP id l02HeBnV093115;
	Tue, 2 Jan 2007 18:40:12 +0100 (CET)
	(envelope-from doginou@dong.ci0.org)
Received: (from doginou@localhost)
	by dong.ci0.org (8.13.7/8.13.4/Submit) id l02HeBc6093114;
	Tue, 2 Jan 2007 18:40:11 +0100 (CET) (envelope-from doginou)
Date: Tue, 2 Jan 2007 18:40:11 +0100
From: Olivier Houchard <cognet@ci0.org>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20070102174011.GA93081@ci0.org>
References: <200701021653.l02GrTiC007919@repoman.freebsd.org>
	<200701021220.09987.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200701021220.09987.jhb@freebsd.org>
User-Agent: Mutt/1.4.1i
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 112424 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jan 2007 17:35:52 -0000

On Tue, Jan 02, 2007 at 12:20:09PM -0500, John Baldwin wrote:
> On Tuesday 02 January 2007 11:53, Olivier Houchard wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=112424
> > 
> > Change 112424 by cognet@hulglah on 2007/01/02 16:52:32
> > 
> > 	Implement a minimalist intr_eoi_src which just calls arm_unmask_irq(),
> > 	so that irq are unmasked after a filter+ithread runs.
> 
> Err, you shouldn't need to mask the IRQ unless you schedule the ithread.   Hmm,
> I'd also prefer it if we didn't pass function handlers to mi_handle_intr() (which
> should be intr_handle() or something, all the MI interrupt code is intr_foo(),
> not mi_foo_intr()) but instead set them in the intr_event and passed them to
> intr_event_create().

Basically the problem is arm_execute_handlers() can't know if we're talking
about an interrupt for which we had a filter, and so we don't have to mask it,
or an interrupt for which we have to schedule the ithread. So it has to be
always masked.

Cheers,

Olivier