From owner-freebsd-chromium@freebsd.org  Sat Aug 22 11:28:11 2015
Return-Path: <owner-freebsd-chromium@freebsd.org>
Delivered-To: freebsd-chromium@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E22C9BEB9E
 for <freebsd-chromium@mailman.ysv.freebsd.org>;
 Sat, 22 Aug 2015 11:28:11 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id E6A301ED0
 for <freebsd-chromium@freebsd.org>; Sat, 22 Aug 2015 11:28:10 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id E429F9BEB9C; Sat, 22 Aug 2015 11:28:10 +0000 (UTC)
Delivered-To: chromium@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3B639BEB9B
 for <chromium@mailman.ysv.freebsd.org>; Sat, 22 Aug 2015 11:28:10 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CF37D1ECF
 for <chromium@FreeBSD.org>; Sat, 22 Aug 2015 11:28:10 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7MBSARR088980
 for <chromium@FreeBSD.org>; Sat, 22 Aug 2015 11:28:10 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: chromium@FreeBSD.org
Subject: [Bug 202368] www/chromium: optionally build chromedriver
Date: Sat, 22 Aug 2015 11:28:11 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: stb@lassitu.de
X-Bugzilla-Status: Open
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: chromium@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-202368-28929-86GapALP4U@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-202368-28929@https.bugs.freebsd.org/bugzilla/>
References: <bug-202368-28929@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-chromium@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: FreeBSD-specific Chromium issues <freebsd-chromium.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-chromium>, 
 <mailto:freebsd-chromium-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-chromium/>
List-Post: <mailto:freebsd-chromium@freebsd.org>
List-Help: <mailto:freebsd-chromium-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-chromium>, 
 <mailto:freebsd-chromium-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Aug 2015 11:28:11 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202368

stb@lassitu.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Closed                      |Open
         Resolution|FIXED                       |---

--- Comment #5 from stb@lassitu.de ---
Unfortunately, the version committed doesn't work.  DRIVER_MAKE_ARGS gets
defined unconditionally, but is never used, and chromedriver is never built.

Something like this is needed:
Index: Makefile
===================================================================
--- Makefile    (revision 394932)
+++ Makefile    (working copy)
@@ -196,6 +196,9 @@
         GPERF="${LOCALBASE}/bin/gperf"
 MAKE_ARGS=    -C out/${BUILDTYPE}
 DRIVER_MAKE_ARGS=chromedriver
+.if ${PORT_OPTIONS:MDRIVER}
+MAKE_ARGS+=    ${DRIVER_MAKE_ARGS}
+.endif

 .include <bsd.port.pre.mk>

-- 
You are receiving this mail because:
You are the assignee for the bug.