From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr 27 19:00:25 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4926D1065676
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2012 19:00:25 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 012FF8FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2012 19:00:25 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3RJ0OaL074391
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 27 Apr 2012 19:00:24 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3RJ0Obj074380;
	Fri, 27 Apr 2012 19:00:24 GMT (envelope-from gnats)
Resent-Date: Fri, 27 Apr 2012 19:00:24 GMT
Resent-Message-Id: <201204271900.q3RJ0Obj074380@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Marcelo Araujo <araujo@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A75FE106566C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 27 Apr 2012 19:00:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8A5C88FC08
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 27 Apr 2012 19:00:01 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3RJ01Jp082644
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Apr 2012 19:00:01 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q3RJ01JH082641;
	Fri, 27 Apr 2012 19:00:01 GMT (envelope-from nobody)
Message-Id: <201204271900.q3RJ01JH082641@red.freebsd.org>
Date: Fri, 27 Apr 2012 19:00:01 GMT
From: Marcelo Araujo <araujo@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/167369: Unnecessary break point.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 19:00:25 -0000


>Number:         167369
>Category:       kern
>Synopsis:       Unnecessary break point.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 27 19:00:24 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Marcelo Araujo
>Release:        CURRENT
>Organization:
FreeBSD
>Environment:
FreeBSD hosta 10.0-CURRENT FreeBSD 10.0-CURRENT #2 r233530M: Mon Apr 23 11:51:58 UTC 2012     araujo@hosta:/usr/obj/usr/src/sys/HOSTA  i386
>Description:
Unnecessary break point.
Obtained from Illumos: changeset 13665	 e5889df1eaac

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: cddl/contrib/opensolaris/cmd/zfs/zfs_main.c
===================================================================
--- cddl/contrib/opensolaris/cmd/zfs/zfs_main.c	(revision 234736)
+++ cddl/contrib/opensolaris/cmd/zfs/zfs_main.c	(working copy)
@@ -763,7 +763,6 @@
 		case ':':
 			(void) fprintf(stderr, gettext("missing size "
 			    "argument\n"));
-			goto badusage;
 			break;
 		case '?':
 			(void) fprintf(stderr, gettext("invalid option '%c'\n"),


>Release-Note:
>Audit-Trail:
>Unformatted: