From owner-freebsd-bugs@FreeBSD.ORG Sat Mar 25 05:10:23 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FC3C16A400 for ; Sat, 25 Mar 2006 05:10:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B723343D4C for ; Sat, 25 Mar 2006 05:10:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2P5AMK0047007 for ; Sat, 25 Mar 2006 05:10:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2P5AMlc047006; Sat, 25 Mar 2006 05:10:22 GMT (envelope-from gnats) Date: Sat, 25 Mar 2006 05:10:22 GMT Message-Id: <200603250510.k2P5AMlc047006@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Bruce Evans Cc: Subject: Re: kern/94772: FIFOs (named pipes) + select() == broken X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bruce Evans List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Mar 2006 05:10:23 -0000 The following reply was made to PR kern/94772; it has been noted by GNATS. From: Bruce Evans To: Oliver Fromme Cc: bug-followup@FreeBSD.org Subject: Re: kern/94772: FIFOs (named pipes) + select() == broken Date: Sat, 25 Mar 2006 16:08:58 +1100 (EST) On Fri, 24 Mar 2006, Oliver Fromme wrote: > I took the liberty to modify your test programs so that > their output is compliant with the regression framework > in src/tools/regression. > > http://www.secnetix.de/~olli/tmp/pipepoll/ Thanks. I made some changes (mostly style fixes) and will send patches io provate mail. > I also modified them so that they perform all tests both > with nameless pipes and with FIFOs, without having to > recompile with different defines. > > Shall I open a separate PR to get them commited to > src/tools/regression/pipepoll? OK with me. I was going to ask whoever committed the fix for this PR (not me) to handle the regression tests too. The followup to this PR is already too long so a separate PR seems best. > Oh, by the way, the patch set that I mailed still has > two failure cases with nameless pipes (I didn't notice > at first because I only tested the NAMEDPIPE case): > > not ok 4 Pipe state 6a: expected POLLHUP; got POLLIN | POLLHUP > not ok 8 Pipe state 6a: expected POLLHUP; got POLLIN | POLLHUP > > Those were broken before, too, so my patch doesn't make > things worse, at least. :-) I'll try to fix those, > too. However, some feedback on my patches so far would > be welcome. This case is unimportant, and as you reported in later mail it is easy to fix but is another fuzzy area POSIX/original-SysV-poll so everyOS does it differently. Bruce