From owner-cvs-all@FreeBSD.ORG Fri Jun 17 12:52:57 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F928106566C; Fri, 17 Jun 2011 12:52:57 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30]) by mx1.freebsd.org (Postfix) with ESMTP id 44C0E8FC20; Fri, 17 Jun 2011 12:52:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by spartan.hamla.org (Postfix) with ESMTP id 1544D1711C; Fri, 17 Jun 2011 08:52:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h= date:date:subject:subject:from:from:x-mailer:message-id :content-type:content-type:content-transfer-encoding :mime-version:in-reply-to:references:received:received; s=aegis; t=1308315176; bh=QDgAk646lyXSTXlOBtVmft45IIOm+n8zMx0As1geOTY=; b= mnDtkiYDiWSoi5eUIwRr9jL2IFM+sAgk/jFpzf93LgwdXEBZUOGgUf8pgKcdsyxD 056Ghs1eKjylSb0YFZBfc2adlWTkDwdspTa8V750DqT1M5jCBr77/L8FUbPgrO5l yPtCIhaaH+bEspKVsdE6jQCg1pMZXaWYV0dddqV2/Vc= X-Virus-Scanned: by ClamAV at spartan.hamla.org Received: from spartan.hamla.org ([127.0.0.1]) by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027) with LMTP id suWb2dA8-I3i; Fri, 17 Jun 2011 08:52:56 -0400 (EDT) Received: from [10.123.112.4] (mobile-166-137-138-047.mycingular.net [166.137.138.47]) by spartan.hamla.org (Postfix) with ESMTPSA id 79B97170E6; Fri, 17 Jun 2011 08:52:55 -0400 (EDT) References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org> <20110617004742.GD19139@magic.hamla.org> In-Reply-To: Mime-Version: 1.0 (iPhone Mail 8C148a) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Message-Id: <0C0893AE-B699-4DAB-AD58-C6075349DC2F@tandon.net> X-Mailer: iPhone Mail (8C148a) From: Sahil Tandon Date: Fri, 17 Jun 2011 08:52:47 -0400 To: "bf1783@gmail.com" Cc: Alexey Dokuchaev , Sahil Tandon , Wen Heping , "cvs-all@freebsd.org" , "ports-committers@freebsd.org" , "cvs-ports@freebsd.org" Subject: Re: cvs commit: ports/sysutils/tmux Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2011 12:52:57 -0000 On Jun 16, 2011, at 11:57 PM, "b. f." wrote: > On 6/17/11, Sahil Tandon wrote: >> On Thu, 2011-06-16 at 16:47:33 +0000, Alexey Dokuchaev wrote: >>=20 >>> On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: >>>> wen 2011-06-16 08:42:28 UTC >>>>=20 >>>> Modified files: >>>> sysutils/tmux Makefile >>>> Log: >>>> - Fix build when CFLAGS is set in /etc/make.conf >>>=20 >>> Hmm, default CPPFLAGS is empty. Judging just from the diff, instead of >>> introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which is= >>> bogus in the first place: -I is preprocessor flag) should be enough (no >>> MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in th= is >>> case as well). I am missing something obvious here? >>=20 >> Because of the way upstream Makefile handles CPPFLAGS, it is not so >> straightforward. This was discussed on freebsd-ports: >>=20 >> http://lists.freebsd.org/pipermail/freebsd-ports/2011-June/068218.html >> http://lists.freebsd.org/pipermail/freebsd-ports/2011-May/067930.html >=20 > But this does not seem so different from the many other ports that set > or alter variables in the port Makefile. If a user overrides these > changes in an automatically and recursively-included Makefile like > __MAKE_CONF, or on the command-line, it it the user's problem. Users > should not pollute their port builds by unconditionally defining > variables in __MAKE_CONF, and I don't think that we should add > elaborations to ports to avoid such mistakes. =20 Yes and I think we get that and I personally agree with your sentiment; howe= ver, I'm not sure that means maintainers need to revert commits that were do= ne to prevent users from shooting their own foot.=