From owner-freebsd-current@FreeBSD.ORG Wed Aug 4 18:05:04 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4260916A4CE for ; Wed, 4 Aug 2004 18:05:04 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7BBC43D4C for ; Wed, 4 Aug 2004 18:05:03 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.155] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BsQ8M-0000Is-00; Wed, 04 Aug 2004 20:05:02 +0200 Received: from [217.83.3.226] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1BsQ8M-0002OZ-00; Wed, 04 Aug 2004 20:05:02 +0200 From: Max Laier To: freebsd-current@freebsd.org Date: Wed, 4 Aug 2004 20:03:00 +0200 User-Agent: KMail/1.6.2 References: <20040804125640.GA78633@stud.fit.vutbr.cz> <20040804130530.GA78973@stud.fit.vutbr.cz> In-Reply-To: <20040804130530.GA78973@stud.fit.vutbr.cz> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_bTSEB15I2x32NcA"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200408042003.07356.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: Divacky Roman cc: Dan Cojocar Subject: Re: problems with altq X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2004 18:05:04 -0000 --Boundary-02=_bTSEB15I2x32NcA Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 04 August 2004 15:05, Divacky Roman wrote: > struct pf_altq *altq, *a; > > if (pa->ticket !=3D ticket_altqs_inactive) { > error =3D EBUSY; > break; > } > altq =3D pool_get(&pf_altq_pl, PR_NOWAIT); > ^^^^^^^^^^ > shouldnt this be initalized to NULL? at least its not nice to have it > uninitalized... hum? $ cd /usr/src/sys/contrib/pf/net && grep pf_altq_pl * <...> pf_ioctl.c: pf_state_pl =3D pf_altq_pl =3D pf_pooladdr_pl =3D NULL; pf_ioctl.c: UMA_DESTROY(pf_altq_pl); pf_ioctl.c: UMA_CREATE(pf_altq_pl, struct pf_altq, "pfaltqpl= "); <...> Or what are you thinking about? Just like Dan Cojocar said in his reply, I can't reproduce your problem=20 here :-\ > On Wed, Aug 04, 2004 at 02:56:40PM +0200, Divacky Roman wrote: > > I am getting this > > pfctl: DIOCADDALTQ: Cannot allocate memory > > if I try to enable altq on pf configured as > > > > altq on $ext_if bandwidth 256Kb cbq queue { ssh_i web other} > > queue ssh_i bandwidth 25% cbq(borrow red) > > queue web bandwidth 25% cbq(borrow red) > > queue other bandwidth 50% cbq(borrow default red) > > > > > > without that "red" it works ok... Now that is strange as it makes no difference in the DIOCADDALTQ call path= =20 whether you use RED or not. Might it be possible that you really are short = on=20 (kernel) memory? =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-02=_bTSEB15I2x32NcA Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBBESTbXyyEoT62BG0RAluXAJ0RGCwC9FL4AS7LbH7FDoqpFRX79ACfSw+y TZw/LBY0AyEx1Ctw23iy1sg= =njby -----END PGP SIGNATURE----- --Boundary-02=_bTSEB15I2x32NcA--