From owner-freebsd-current@FreeBSD.ORG Mon Apr 7 11:55:55 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCCF2106566C for ; Mon, 7 Apr 2008 11:55:55 +0000 (UTC) (envelope-from jille@quis.cx) Received: from smtp2.versatel.nl (smtp2.versatel.nl [62.58.50.89]) by mx1.freebsd.org (Postfix) with ESMTP id 419178FC1D for ; Mon, 7 Apr 2008 11:55:54 +0000 (UTC) (envelope-from jille@quis.cx) Received: (qmail 8625 invoked by uid 0); 7 Apr 2008 11:55:52 -0000 Received: from ip83-113-174-82.adsl2.versatel.nl (HELO istud.quis.cx) ([82.174.113.83]) (envelope-sender ) by smtp2.versatel.nl (qmail-ldap-1.03) with SMTP for < >; 7 Apr 2008 11:55:52 -0000 Received: by istud.quis.cx (Postfix, from userid 100) id 371C439820; Mon, 7 Apr 2008 13:55:51 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on istud.quis.cx X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from [192.168.1.4] (ille [192.168.1.4]) by istud.quis.cx (Postfix) with ESMTP id 6650C39819; Mon, 7 Apr 2008 13:55:48 +0200 (CEST) Message-ID: <47FA0BC1.3010803@quis.cx> Date: Mon, 07 Apr 2008 13:55:45 +0200 From: Jille User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Ed Schouten References: <47F95B6D.80006@quis.cx> <20080407083746.GL5934@hoeg.nl> In-Reply-To: <20080407083746.GL5934@hoeg.nl> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: werase patch for src/contrib/top X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2008 11:55:55 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Ed, After an hour of reading style(9), I've fixed my patch, thanks for pointing out. Unixtop seems to be on SourceForge now, so I will submit it to their patch-tracker. I'm running FreeBSD 6.3 and top seems to be 'outdated' [quis@istud ~]$ top -v top: version 3.5beta12 I don't know whether this is 'fixed' in CURRENT. - -- Jille Ed Schouten schreef: | Hi Jille :-) | | * Jille Timmermans wrote: |> I've patched top (in src/contrib) to accept ^W in line editing mode (eg |> when killing a process (hit 'k')) |> |> The patch is attached, and I hope mailman won't eat it, or else: |> http://junk.quis.cx/NbVJSKxn/top-werase-patch.diff |> there it is :) |> I took the RELENG_6 version, and editted that one. | | Apart from some style(9) issues, it looks great. Unfortunately the | top(8) source code is not maintained by FreeBSD. Its website seems to be | http://unixtop.org/, though I couldn't find an email address there where | you can submit patches. | | You'd better file a PR, to make sure it won't get lost. The patch seems | to work on CURRENT as well. Thanks! | -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkf6C8EACgkQacI4LQTe9EV/4gCgkEMu3snMy4MKaWbp7UGYNkyX /cMAn048hOyeC3YQBMlD0Ige3qsSrU2v =ir00 -----END PGP SIGNATURE-----