From owner-dev-commits-src-all@freebsd.org Thu Apr 8 22:19:23 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BD2965C244A for ; Thu, 8 Apr 2021 22:19:23 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FGbK70VPZz4ms5 for ; Thu, 8 Apr 2021 22:19:22 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oo1-f44.google.com with SMTP id 125-20020a4a1a830000b02901b6a144a417so872989oof.13 for ; Thu, 08 Apr 2021 15:19:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=bSLpcVXyXg244hDTLqlRCq2ypmpZ5dHDYGCp1Kth4/0=; b=KiklNnPXO7k9LjAEes2jRqaCEdDYY6/NywRSi1WiaAHo30uYfxSy8GEisqdq315SL+ e9DtCxLDzq9DiEgD4XCJreQpaIdePshwTW4i8L6RdthNcZcaeRSyPW44ZYfnO8J9V9QV fCIdXTz3rDHO7Yy6RaGC5/6vAq80jFJBIKHEWU4WrOHetSiX4rL2Yw+1Fw6hSU/LYG8u LlOZajZDoUh0ppjEzruHDR+3tSrb1DWN551daqLjiA9FUa0RSY36Nrkr4qeP5dK05eFU kVRmTPMxkQTBdtfUCUnUA3THAuXlj9Ev9scxchm6JrShqTtygNt+i5h0RBO3v1TXlrVg u3Ww== X-Gm-Message-State: AOAM532cjF2STW+GGRRCBiOnCrp0fEFtANiwi7gtQF08m/nv5ZOMnWLf vMPRD4FS1HwEuxfpMpRUl8E73TqI0Ul4WEJQbhI= X-Received: by 2002:a4a:4005:: with SMTP id n5mt8209042ooa.61.1617920361881; Thu, 08 Apr 2021 15:19:21 -0700 (PDT) MIME-Version: 1.0 References: <202104082134.138LYPCH015380@gitrepo.freebsd.org> In-Reply-To: <202104082134.138LYPCH015380@gitrepo.freebsd.org> From: Alan Somers Date: Thu, 8 Apr 2021 16:19:10 -0600 Message-ID: Subject: Re: git: 5061d5a0cfaf - stable/12 - mount_nullfs: rename a local variable Cc: src-committers , "" , dev-commits-src-branches@freebsd.org X-Rspamd-Queue-Id: 4FGbK70VPZz4ms5 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RWL_MAILSPIKE_GOOD(0.00)[209.85.161.44:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MISSING_TO(2.00)[]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.161.44:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.161.44:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.161.44:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 22:19:23 -0000 On Thu, Apr 8, 2021 at 3:34 PM Alan Somers wrote: > The branch stable/12 has been updated by asomers: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=5061d5a0cfaf68a6891db82f6bd26ad3e72e87b1 > > commit 5061d5a0cfaf68a6891db82f6bd26ad3e72e87b1 > Author: Alan Somers > AuthorDate: 2021-02-12 18:30:52 +0000 > Commit: Alan Somers > CommitDate: 2021-04-08 21:32:55 +0000 > > mount_nullfs: rename a local variable > > The "source" variable was introduced in r26072, probably as the > traditional counterpart to "target". But the "source"/"target" names > suggest the opposite of their actual meaning. With ln, for example, > the > source is the real file and the target is the newly created link. In > mount_nullfs the meaning is the opposite: the target is the existing > file system and the source is the newly created mountpoint. Better to > use "target"/"mountpoint" terminology, which matches the man page. > > Sponsored by: Axcient > > (cherry picked from commit f540cb27a23719d88b7e5143be6e62f75dd25f08) > Oops, this broke the build. I did a build test, but forgot to check that the build actually passed. I'll fix it shortly. -Alan