From owner-svn-src-all@freebsd.org Tue Feb 26 17:28:57 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCA9615202DD; Tue, 26 Feb 2019 17:28:56 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69B188FE27; Tue, 26 Feb 2019 17:28:56 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-ot1-x342.google.com with SMTP id m1so11793911otf.5; Tue, 26 Feb 2019 09:28:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=61p1ihfhQhP5HgChIZ7Nk0cwJ9Y+iMzlC+ywDrNjalE=; b=P4R4JZqdexPZpbHKh5H70fhHw01sQRnwjBnIlpW9afdWBfAysYC2XqdwEdCGg6RXkw NNts9vGN9ejlZlSIGLcBPKARaxfXrhCKGNP5ORgfSMT26FldjGWy3PIP3soWGB6gdAV9 bUbY6ITmZ88DE2ldGRUwFLPNlp+Ls3WFYsfwECP+g1Mpn9IwzcJLdJp+1wycBEca7+gj C5NBmuWMwPrAVx5z3lUshareOpJwG5KXm1KRtrRbcAh8wnGEQBMAYq+D8x+iaaYoBttR e6CUEpMvdTd9CTL2i0ZPktIWRwjdk6pCtKpOm5GN4jpu8wkHTkIo6nwNGToxgR68/eMK kwFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=61p1ihfhQhP5HgChIZ7Nk0cwJ9Y+iMzlC+ywDrNjalE=; b=FfM5VPx+bVNslgMZULvbTuGY4PvJ1XgAq/11JbNJxEzWIRowutvpD1howEuCac41Vs S07krayIq6ZVUZTvjpW9IcHJcuPxYfyeelOkZPty/6QTy8TJqH5kKUp23sJPXdmaC88Y iXWHPbz7DGhtu/5azYcYj7BfznQCHtJEZU9gCn2yviQ2JJvW/RAZN4+gTuoe4w3e24cJ M0HyekLqTm63D/qirXQKI7HxEPP/CzjOn13kTMfKOZo8jadR64+vTzZbRmLjwQKNj4R7 f9y2TU3CTa0FcR+FesR2RysE3M8hCVeNadudgg9dq6uNPJI1URT42vNDP3jvCF5OTZiS kh5Q== X-Gm-Message-State: AHQUAuYTAM+61DFvRyZZmLcP/IRknpWO0DPWJt3VcPD5yz8H94STL2Po BxYXYfuYciaFahx0YIK6w9+1sFRFM9YqQCIULoZ+AKCy X-Google-Smtp-Source: AHgI3IaDSdRvYs2/qblzoaE5BiR/Rdzo61/W50+qlY/Wi9zbcdj3o0iCJ+Y6Ze9Wu4epcGWq5ELA4o40+bl9YuuVUWc= X-Received: by 2002:a05:6830:1092:: with SMTP id y18mr16061756oto.125.1551202135450; Tue, 26 Feb 2019 09:28:55 -0800 (PST) MIME-Version: 1.0 References: <201902261659.x1QGxkl0046685@pdx.rh.CN85.dnsmgr.net> <20a4a5ab-f088-537b-8666-e6c6f43170a9@FreeBSD.org> In-Reply-To: <20a4a5ab-f088-537b-8666-e6c6f43170a9@FreeBSD.org> From: Benjamin Kaduk Date: Tue, 26 Feb 2019 11:28:44 -0600 Message-ID: Subject: Re: svn commit: r344569 - in head/cddl/contrib/opensolaris: cmd/zfs lib/libzfs/common To: John Baldwin Cc: rgrimes@freebsd.org, Cy Schubert , Baptiste Daroussin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 69B188FE27 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.964,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 17:28:57 -0000 On Tue, Feb 26, 2019 at 11:19 AM John Baldwin wrote: > On 2/26/19 8:59 AM, Rodney W. Grimes wrote: > >> On Tue, Feb 26, 2019 at 10:14 AM Cy Schubert > > >> wrote: > >> > >>> On February 26, 2019 7:48:27 AM PST, Cy Schubert < > >>> Cy.Schubert@cschubert.com> wrote: > >>>> On February 26, 2019 12:18:35 AM PST, Baptiste Daroussin > >>>> wrote: > >>> > >> > >> [trimming the unneeded pile of commit body] > >> > >> > >>>> This broke my systems, many filesystems fail to mount causing nullfs > >>>> late mounts to fail. No details now until tonight. > >>>> > >>>> Suggest we back this out until it is properly tested. > >>> > >>> Nested zfs filesystems seem not to be handled properly or possibly not > >>> supported any more. This explains my mail gateway also not mounting all > >>> filesystems in /home. It was odd that dovecot stopped working. > >>> > >>> The symptom of the problem is zfs mount -a no longer mounts all > >>> filesystems. Zfs mount fails saying the filesystem is already mounted. > The > >>> workaround is to zfs umount each affected zfs dataset by hand and zfs > mount > >>> it by hand. > >>> > >>> Generally this has screwed up sites that have hundreds (in my case 122) > >>> zfs datasets. The work around might be to script testing each mount, > >>> unmounting and remounting if necessary. > >>> > >>> I'm being sarcastic about creating an rc script to clean this up. This > >>> needs to be backed out and tested properly before being committed. > >>> > >>> > >> I don't know what you mean by "nested zfs filesystems" -- do you mean a > >> zpool within a zvol? > >> That has been unsupported for a long time, IIRC. And > > That had better not be unsupported, that is the prefered technology > > for all of the virtualization stuff, bhyve, virtualbox, qemu, etc. > > I think Ben is referring to using the nested zpool on the host itself > rather > than in the guest. We do actually let you do such crazy things I think (I > use UFS in my VMs usually and fsck on the host against > /dev/zvol/bhyve/p2 > can be faster than fsck in the booted guest), but normally the host just > hosts > the zvol and the guest manages filesystems in the volume. Mounting the > nested zpool on the host is probably best characterized as running with > scissors. > > Exactly so; thanks for clarifying. -Ben