From owner-svn-ports-all@FreeBSD.ORG  Sun Dec 29 10:22:53 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9326E810;
 Sun, 29 Dec 2013 10:22:53 +0000 (UTC)
Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4D5301957;
 Sun, 29 Dec 2013 10:22:53 +0000 (UTC)
Received: by mx1.stack.nl (Postfix, from userid 65534)
 id B14DB359305; Sun, 29 Dec 2013 11:22:50 +0100 (CET)
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mailscan02.stack.nl
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,
 TW_SV autolearn=ham version=3.3.2
X-Spam-Relay-Country: XX
X-Spam-DCC: EATSERVER: mailscan02.stack.nl 1166; Body=1 Fuz1=1 Fuz2=1
Received: from mud.stack.nl (mud.stack.nl [IPv6:2001:610:1108:5011::70])
 by mx1.stack.nl (Postfix) with ESMTP id A49B63592EF;
 Sun, 29 Dec 2013 11:22:48 +0100 (CET)
Received: by mud.stack.nl (Postfix, from userid 801)
 id 8C1943C6024; Sun, 29 Dec 2013 11:22:48 +0100 (CET)
Date: Sun, 29 Dec 2013 11:22:48 +0100
From: Johan van Selst <johans@FreeBSD.org>
To: Rusmir Dusko <nemysis@FreeBSD.org>
Subject: Re: svn commit: r337945 - head/graphics/webp
Message-ID: <20131229102248.GA70632@mud.stack.nl>
References: <20131229093309.GA36631@misterbean90now>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi"
Content-Disposition: inline
In-Reply-To: <20131229093309.GA36631@misterbean90now>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Dec 2013 10:22:53 -0000


--6c2NcOVqGQ03X4Wi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Rusmir Dusko wrote:
> According to
> http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html
> is better to use
> OPTIONS_DEFINE=X11
> OPTIONS_SUB=    yes

Actually, that text doesn't say which way is better, but explains that
both notations are equivalant. I don't really have a preference, but am
happy to change it to OPTIONS_SUB if people think this is more readable.

> .include <bsd.port.options.mk>
> X11_CONFIGURE_DISABLE=--with-glincludedir=/dev/null

I don't think there is an opt_CONFIGURE_DISABLE feature, but only
opt_CONFIGURE_ENABLE, which does not do what I need here. I consider the
original CONFIGURE_ARGS+= easier to understand, in this case anyway.


Regards,
Johan

--6c2NcOVqGQ03X4Wi
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iF4EAREIAAYFAlK/9/cACgkQAEpMHW8nCPTIggEAy8jzNkLL2N8AQ5F5BroOlf81
0GdlZhA6MR3hgjUyQckBALiX5cbO5Tpnjct/eFFaHrhS1o5ribjYD01UWrLXLXo4
=RyBS
-----END PGP SIGNATURE-----

--6c2NcOVqGQ03X4Wi--