Date: Sun, 29 Dec 2013 11:22:48 +0100 From: Johan van Selst <johans@FreeBSD.org> To: Rusmir Dusko <nemysis@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r337945 - head/graphics/webp Message-ID: <20131229102248.GA70632@mud.stack.nl> In-Reply-To: <20131229093309.GA36631@misterbean90now> References: <20131229093309.GA36631@misterbean90now>
next in thread | previous in thread | raw e-mail | index | archive | help
--6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Rusmir Dusko wrote: > According to > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html > is better to use > OPTIONS_DEFINE=X11 > OPTIONS_SUB= yes Actually, that text doesn't say which way is better, but explains that both notations are equivalant. I don't really have a preference, but am happy to change it to OPTIONS_SUB if people think this is more readable. > .include <bsd.port.options.mk> > X11_CONFIGURE_DISABLE=--with-glincludedir=/dev/null I don't think there is an opt_CONFIGURE_DISABLE feature, but only opt_CONFIGURE_ENABLE, which does not do what I need here. I consider the original CONFIGURE_ARGS+= easier to understand, in this case anyway. Regards, Johan --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iF4EAREIAAYFAlK/9/cACgkQAEpMHW8nCPTIggEAy8jzNkLL2N8AQ5F5BroOlf81 0GdlZhA6MR3hgjUyQckBALiX5cbO5Tpnjct/eFFaHrhS1o5ribjYD01UWrLXLXo4 =RyBS -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131229102248.GA70632>