From owner-svn-src-all@freebsd.org Sun Feb 4 18:08:32 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F24ADEE5C9D; Sun, 4 Feb 2018 18:08:31 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: from mail-pg0-x22f.google.com (mail-pg0-x22f.google.com [IPv6:2607:f8b0:400e:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2888E6B2A5; Sun, 4 Feb 2018 18:08:31 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: by mail-pg0-x22f.google.com with SMTP id g2so715439pgn.7; Sun, 04 Feb 2018 10:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ib0BItbcjswz/FCRl2Fs+hK5UUVSsa2T/fzS9JQqvhI=; b=eTUChHaIXyXeoN0Y5WPuw4y3EOoBbROU/rvYQ3XY5QkNZ17MFEJHAKtRft6scIyguA gtQtUNZaMFxZ+kETtgEVtWzhRVxyFNCvTE5LbK+18sft9wwnBWlNsPuyl6wAkwcq4T2T 1kkSsvc22Qko5I76720xshq0KUJkM47blbRQE5mJSi1uaUs9MMgGGz9a/Rvh+gXdKA3b OJhfnW2fEB18ExfETmPfnRoYPAy846NXlRs1Qn4pBqQoSlSnwjCVdQYk1S2m2G6zd0KD RUE3b2O8oaczjSOynFgkITbmtm7oKIvepL9nm5V4MBQtU7w06g5G1JBRxLZ0XzrdOK1D 0cmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ib0BItbcjswz/FCRl2Fs+hK5UUVSsa2T/fzS9JQqvhI=; b=VLybhCLftCS7ZGG4pq0Cg6lwETXIETYKPku0QB/L3wpIWqZivq8svxPgsaAgEBBBcT 70DUK113RkfK835V9lf75uwZlHGAdv2ko4cRAKq6V7Jafyl/CFw9+0LaaxfKY+o6efTF h1x73z2NibHYzFJh0bbck625clNwtrx+xNlxl2sc2JzRhERbID+2ol7m54LI3D/sNy08 PjUbA4LD1yHwJaN2vo7TeM7GhUA+Ml+/6MmDj2UNBOiVepIK7oORblzZl63E7d6Peb8n dKUuCeWOqTPNbcdRTVNJlZkvfGvjQ/TbhAiHgAliZOuggOFXYn7mSXili82J5FAmhM28 OJzg== X-Gm-Message-State: AKwxytfnD5uJFjeyD8ypLKxwF4y3N+w1s2hJDj40rm4KaxFHugmTwLWg VfnMnw/pHjd2ysEZZh26q23A X-Google-Smtp-Source: AH8x227KlzeUzsAAhR2fPlXEjL9sbQ7G0FL9BytSVJgKo1lFYG6NFEE6V7Ak/PPPH4Wh283IPGU/5w== X-Received: by 10.99.55.65 with SMTP id g1mr27810546pgn.284.1517767709805; Sun, 04 Feb 2018 10:08:29 -0800 (PST) Received: from [192.168.1.3] (c-67-188-30-11.hsd1.ca.comcast.net. [67.188.30.11]) by smtp.googlemail.com with ESMTPSA id z19sm14583896pff.3.2018.02.04.10.08.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Feb 2018 10:08:29 -0800 (PST) Subject: Re: svn commit: r328489 - head/sys/conf To: "O. Hartmann" , David Wolfskill Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801272013.w0RKDaMU098200@repo.freebsd.org> <20180127214755.3c59661e@thor.intern.walstatt.dynvpn.de> <98501f75-1a1b-9221-c52d-24415230a886@gmail.com> <20180129130022.GT1125@albert.catwhisker.org> <20180204133337.3d03f01d@thor.intern.walstatt.dynvpn.de> From: Jason Harmening Message-ID: Date: Sun, 4 Feb 2018 10:22:31 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180204133337.3d03f01d@thor.intern.walstatt.dynvpn.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Feb 2018 18:08:32 -0000 On 02/04/18 04:33, O. Hartmann wrote: > Am Mon, 29 Jan 2018 05:00:22 -0800 > David Wolfskill schrieb: > >> On Mon, Jan 29, 2018 at 02:10:04AM -0800, Jason Harmening wrote: >>>> >>>> This happens now if PORTS_MODULE=x11/nvidia-driver is defined in /etc/src.conf: >>>> >>>> [...] >>>> --- kernel-install --- >>>> mkdir -p /boot/kernel >>>> install -p -m 555 -o root -g wheel kernel /boot/kernel/ >>>> --- ports-install --- >>>> Variable OBJTOP is recursive. >>>> >>>> make[8]: stopped >>> ... >>> >>> David sent me logs of the failing case; thanks David! >> >> Happy to help! :-) >> >>> The failure happens when buildkernel and installkernel are run >>> separately instead of all-up, e.g. 'make kernel'. The installkernel >>> step is leaving MK_AUTO_OBJ=no in the env passed to the port build. It >>> looks like at least one of the install stages of nvidia-driver needs to >>> generate temporary output, which leads to confusion when the port isn't >>> built as though it's an in-tree component. >>> >>> Can you guys try out the attached patch? >> >> I tried it both on my build machine (which does not use kernel modules >> from ports, and thus did not exhibit the problem -- but I thought that >> verifying that the patch did not break that case worth checking) and on >> my laptop (which did exhibit the problem). >> >> It worked in both cases with no issues for me. >> >> Thanks! :-) >> >> Peace, >> david > > The problem still persists! > > I'm on CURRENT, FreeBSD 12.0-CURRENT #32: Sun Feb 4 09:41:39 CET 2018 amd64, the source > tree is at revision 328839. > > > I use WITH_META_MODE=YES in /etc/src.conf. My /etc/make.conf consists of a .include > statement which reels in /usr/local/etc/ports.conf in which I define everything outside > the source tree for ports (in case of the nvidia driver, its DISTVERSION). This worked > before and should work again. Today I checked out a completely fresh /usr/src and gleanced > the /usr/obj folder and rebuilt the system - and get the error again: > > [...] > ===> Ports module x11/nvidia-driver (install) > cd ${PORTSDIR:-/usr/ports}/x11/nvidia-driver; env -u CC -u CXX -u CPP -u MAKESYSPATH > MAKEFLAGS="-j 4 -J 15,16 .MAKE.LEVEL.ENV=MAKELEVEL KERNEL=kernel MK_AUTO_OBJ=no ^^^^^ Looks like you haven't applied the patch? MK_AUTO_OBJ being left set in MAKEFLAGS by installkernel was part of the problem. That said, the fix I have up for review is slightly different: https://reviews.freebsd.org/D14143 > TARGET=amd64 TARGET_ARCH=amd64" SYSDIR=/usr/src/sys > PATH=/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin > SRC_BASE=/usr/src OSVERSION=1200056 WRKDIRPREFIX=/usr/obj/usr/src/amd64.amd64/sys/THOR > make -B deinstall reinstall ===> Deinstalling for nvidia-driver ===> Deinstalling > nvidia-driver-387.34 Updating database digests format: . done Checking integrity... done > (0 conflicting) Deinstallation has been requested for the following 1 packages (of 0 > packages in the universe): > > Installed packages to be REMOVED: > nvidia-driver-387.34 > > Number of packages to be removed: 1 > > The operation will free 99 MiB. > [1/1] Deinstalling nvidia-driver-387.34... > [1/1] Deleting files for nvidia-driver-387.34: .......... done > ===> Staging for nvidia-driver-387.34 > ===> nvidia-driver-387.34 depends on file: /usr/local/lib/libGL.so - found > ===> nvidia-driver-387.34 depends on file: /usr/local/libdata/pkgconfig/x11.pc - found > ===> nvidia-driver-387.34 depends on file: /usr/local/libdata/pkgconfig/xorg-server.pc > - found ===> nvidia-driver-387.34 depends on file: /usr/local/libdata/pkgconfig/xext.pc > - found ===> Generating temporary packing list > ===> src (install) > ===> src/nvidia (install) > Variable OBJTOP is recursive. > > make[8]: stopped > in /usr/obj/usr/src/amd64.amd64/sys/DUMMBOX/usr/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86_64-387.34/src/nvidia > *** Error code 2 > > > > Oliver >