From owner-svn-src-head@FreeBSD.ORG Sat Mar 17 05:40:13 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 22032106566B; Sat, 17 Mar 2012 05:40:13 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from fallbackmx10.syd.optusnet.com.au (fallbackmx10.syd.optusnet.com.au [211.29.132.251]) by mx1.freebsd.org (Postfix) with ESMTP id 69AB38FC14; Sat, 17 Mar 2012 05:40:11 +0000 (UTC) Received: from mail04.syd.optusnet.com.au (mail04.syd.optusnet.com.au [211.29.132.185]) by fallbackmx10.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q2H5e5QM006711; Sat, 17 Mar 2012 16:40:05 +1100 Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail04.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q2H5dsoh028896 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 17 Mar 2012 16:39:55 +1100 Date: Sat, 17 Mar 2012 16:39:54 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Dimitry Andric In-Reply-To: <201203162319.q2GNJjx5039482@svn.freebsd.org> Message-ID: <20120317162754.I1530@besplex.bde.org> References: <201203162319.q2GNJjx5039482@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233052 - head/share/mk X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2012 05:40:13 -0000 On Fri, 16 Mar 2012, Dimitry Andric wrote: > Log: > Change the style of share/mk/bsd.sys.mk to that of the other bsd.*.mk > files, and style.Makefile(5), where applicable. While here, update the > link to the gcc warning documentation. Thanks. I rather liked the "^.* foo" style for making ifdefs less unreadable, but it didn't look like it was written here, and it is a sign of other problems that so many nested ifdefs are used. It only used a single space of each level of indentation, so the indentation was still hard too see. The "other bsd.*.mk" files don't include bsd.cpu.mk. This still uses the "^. *foo" style (and is now the only *.mk file one that does this). For assignments, it mostly uses a different unusual style -- just the normal C style of a single space before and after '=' (or '+='). Weird formattings of assignments are harder to grep for than weird formattings of ".foo", so I didn't try looking for them all. Bruce