Date: Wed, 21 Dec 2016 23:02:12 +0100 From: Jilles Tjoelker <jilles@stack.nl> To: Conrad Meyer <cem@freebsd.org> Cc: Adrian Chadd <adrian.chadd@gmail.com>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r310138 - head/lib/libc/stdio Message-ID: <20161221220212.GA97256@stack.nl> In-Reply-To: <CAG6CVpUoUa=LkqWvSovLXkfGhOQ0FLxrbHKwVh%2B0BCgHjYz0qg@mail.gmail.com> References: <201612160144.uBG1ipjW016736@repo.freebsd.org> <CANCZdfrNu0=qPuMX8SA2H-MUXGb5rei06_dQg9XGp-Miu3Xsfg@mail.gmail.com> <e2056221-26ad-5108-3385-865abff12d78@FreeBSD.org> <49460793.UcUNovQMDa@ralph.baldwin.cx> <CAJ-Vmone4dyiDdmtppzZEGW=rKGW9CkRWGvFbQb5D3bkyiSs9A@mail.gmail.com> <CAG6CVpUBejZQbMEnhq3wp5b-hHy9jhoXY256n1uzHCO4dUD=Cw@mail.gmail.com> <1482281779.48539.41.camel@freebsd.org> <CAJ-Vmomfa11mACJS=4pV3H-usd8LvOSC9PY=Q%2BiioFhdAUXuUg@mail.gmail.com> <CAG6CVpUoUa=LkqWvSovLXkfGhOQ0FLxrbHKwVh%2B0BCgHjYz0qg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 20, 2016 at 06:04:31PM -0800, Conrad Meyer wrote:
> On Tue, Dec 20, 2016 at 5:56 PM, Adrian Chadd <adrian.chadd@gmail.com> wrote:
> > Here's my reason for removal.
> > Plenty of us are looking to be able to build bits of the BSD source
> > tree as part of other non FreeBSD systems, especially if they're
> > involved in bootstrapping.
> Understood, however:
> > That means that it needs to be compilable
> > by a non-FreeBSD-modified compiler. Ideally this means we'd stick to
> > mostly POSIX options source code that we can compile with unmodified
> > compilers, and we push non-standard stuff into otherly-named
> > functions.
> Yeah, this isn't actually a problem. printf("%b", foo) compiles fine
> with non-modified compilers.
It compiles only if you disable format string warnings that should not
be disabled for any serious software development, in my humble opinion.
It will build, but not in a way I can call "fine".
This indeed makes it very hard to justify extensions to format strings.
Special formatting will need to use new functions.
--
Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161221220212.GA97256>