From owner-svn-src-head@freebsd.org Fri Feb 17 10:59:04 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E377ACE24BB for ; Fri, 17 Feb 2017 10:59:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 824FC1AF4; Fri, 17 Feb 2017 10:59:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id v77so1900146wmv.0; Fri, 17 Feb 2017 02:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G7RmT3PGRJwLYuFQ9eBg8LvRUwd9FWPpmh87S46onYM=; b=INWg/Y3fT1tEoBIRlV/KiM4VCL079D8B+Q1axCioZETKjvxXJBvtf0EaTFe9iK2niw yf0rGsCWhmre1dUt9v1AdcmS1/ERjsRxvNxmRQDtFZxS/gwoYkGILIFqIWWZqnZ8GLRg XMLg+aS9Z5OtJyk01YMZOxNleSfczzHIjZA3bgpinKKIb+On3X6c/cS1dL+xWwv6MirD qUuQ+7zSAIIKZlQWZLqASw/tfZI8IxTA2iqMbzwadKHOdqXPvKA5doJA3KjMd6jlQJgL EyPOqgG+nFw+HoI7U8zlWOTO0fAXNiKn9IsABhHw52bxA0XcT2tKtUcovq7TD/pohHtc sGqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G7RmT3PGRJwLYuFQ9eBg8LvRUwd9FWPpmh87S46onYM=; b=PyqY/127f4/x6KQdY75L1iW+NST1fZ3xjzhEmak6AExrlh7wI4roSYEifp4qteg+HK DPYsXQGILpAADXcJqciwmmjm3DeVC4epQt9HxxU+yO9t7q5j0F55Py+rMsubRVnt8ZNn 309H8IB2NSlSa7R7f6iUnhl2Xt6sh9//mYCs3AIqpIzzEQGrhCHhVkhu+R0XIxDJcUSV AmQJvc00JJktfieWoGywjTsXAYYuEsT20L6jZlCvMz/w+EbShNAQ9VATltE4msu2U5z1 PoRuWLZGLw4D/lBAGe2jJOEHww85gVrF82FA4/UReVJgQArRey33AOke5sA44CRPHVnH DCeg== X-Gm-Message-State: AMke39nTEB2Fi2rU1Jnd3orlfgmP+suwvk72DSXI4dcqcEPNFWw1ylWRWANeyP0OMWIIhw== X-Received: by 10.28.127.13 with SMTP id a13mr1543581wmd.96.1487329141602; Fri, 17 Feb 2017 02:59:01 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id d1sm12520986wrb.62.2017.02.17.02.59.00 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 17 Feb 2017 02:59:01 -0800 (PST) Date: Fri, 17 Feb 2017 11:58:58 +0100 From: Mateusz Guzik To: meloun.michal@gmail.com Cc: Mateusz Guzik , svn-src-head@freebsd.org Subject: Re: svn commit: r313855 - head/sys/kern Message-ID: <20170217105858.GC30217@dft-labs.eu> References: <201702170539.v1H5de82032123@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 10:59:05 -0000 On Fri, Feb 17, 2017 at 11:55:36AM +0100, Michal Meloun wrote: > > > On 17.02.2017 6:39, Mateusz Guzik wrote: > > Modified: head/sys/kern/kern_sx.c > > ============================================================================== > > --- head/sys/kern/kern_sx.c Fri Feb 17 05:22:58 2017 (r313854) > > +++ head/sys/kern/kern_sx.c Fri Feb 17 05:39:40 2017 (r313855) > > @@ -364,7 +364,11 @@ _sx_xunlock(struct sx *sx, const char *f > > WITNESS_UNLOCK(&sx->lock_object, LOP_EXCLUSIVE, file, line); > > LOCK_LOG_LOCK("XUNLOCK", &sx->lock_object, 0, sx->sx_recurse, file, > > line); > > +#ifdef LOCK_PROFILING > > _sx_xunlock_hard(sx, (uintptr_t)curthread, file, line); > > +#else > > + __sx_xunlock(sx, curthread, file, line); > > +#endif > > TD_LOCKS_DEC(curthread); > > } > > > > > > This breaks armv6 kernel. > Michal > > > /usr2/Meloun/git/tegra/sys/kern/kern_sx.c:370:2: error: implicit > declaration of function '__sx_xunlock' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > __sx_xunlock(sx, curthread, file, line); > ^ > /usr2/Meloun/git/tegra/sys/kern/kern_sx.c:370:2: note: did you mean > '_sx_xunlock'? > /usr2/Meloun/git/tegra/sys/kern/kern_sx.c:358:1: note: '_sx_xunlock' > declared here > _sx_xunlock(struct sx *sx, const char *file, int line) > ^ > 1 error generated. > Should work with r313865. -- Mateusz Guzik