From owner-cvs-all@FreeBSD.ORG Wed Oct 17 10:48:59 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2E1816A418; Wed, 17 Oct 2007 10:48:59 +0000 (UTC) (envelope-from simon@benji.nitro.dk) Received: from mx.nitro.dk (zarniwoop.nitro.dk [83.92.207.38]) by mx1.freebsd.org (Postfix) with ESMTP id 58AD913C45A; Wed, 17 Oct 2007 10:48:59 +0000 (UTC) (envelope-from simon@benji.nitro.dk) Received: from benji.nitro.dk (unknown [192.168.3.39]) by mx.nitro.dk (Postfix) with ESMTP id CC1701E8C0F; Wed, 17 Oct 2007 10:33:30 +0000 (UTC) Received: by benji.nitro.dk (Postfix, from userid 2000) id 01903FD13; Wed, 17 Oct 2007 12:33:39 +0200 (CEST) Date: Wed, 17 Oct 2007 12:33:39 +0200 From: "Simon L. Nielsen" To: Stefan Esser Message-ID: <20071017103338.GB1003@zaphod.nitro.dk> References: <200710170727.l9H7Rpk3028513@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710170727.l9H7Rpk3028513@repoman.freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/locate/locate locate.rc updatedb.sh X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 10:48:59 -0000 On 2007.10.17 07:27:51 +0000, Stefan Esser wrote: > se 2007-10-17 07:27:51 UTC > > FreeBSD src repository > > Modified files: > usr.bin/locate/locate locate.rc updatedb.sh > Log: > The previous version included too many file system types in the scan, > since "local" includes also synthetic file systems (e.g. /dev, /proc) > and loopback mounts. > > This version uses lsvfs to identify file system types that are local > and additionally not synthetik, loopback mounts, or read-only. This > has been suggested by Craig Rodrigues half a year ago. The patch that > has been committed is based on his suggestion, but slightly modified. Are you sure all read-only file systems should be excluded? I quite often have systems with some filesystem mounted read-only (often /), though granted most of those are "embedded" which doesn't run updatedb. Which kind of file systems were you thinking should be excluded by the RO part which isn't already removed by loopback|network|synthetic ? I'm not certain read-only shouldn't be excluded, but I just want to point out there are cases where read-only still might be a local and interesting file system. -- Simon L. Nielsen