From owner-freebsd-current Fri Mar 24 14:38:32 2000 Delivered-To: freebsd-current@freebsd.org Received: from sentry.gw.tislabs.com (sentry.gw.tislabs.com [192.94.214.100]) by hub.freebsd.org (Postfix) with ESMTP id 6761237BE77 for ; Fri, 24 Mar 2000 14:38:19 -0800 (PST) (envelope-from stevek@tislabs.com) Received: by sentry.gw.tislabs.com; id RAA27210; Fri, 24 Mar 2000 17:39:52 -0500 (EST) Received: from clipper.gw.tislabs.com(10.33.1.2) by sentry.gw.tislabs.com via smap (V5.5) id xma027203; Fri, 24 Mar 00 17:39:39 -0500 Received: from mufasa.va.tislabs.com (mufasa.va.tislabs.com [192.168.10.18]) by clipper.gw.tislabs.com (8.9.3/8.9.1) with ESMTP id RAA02312; Fri, 24 Mar 2000 17:37:06 -0500 (EST) Received: from localhost (stevek@localhost) by mufasa.va.tislabs.com (8.9.3/8.9.3) with ESMTP id RAA13956; Fri, 24 Mar 2000 17:40:26 -0500 (EST) (envelope-from stevek@mufasa.va.tislabs.com) Date: Fri, 24 Mar 2000 17:40:26 -0500 (EST) From: Steve Kiernan To: Garrett Wollman Cc: Steve Kiernan , freebsd-current@FreeBSD.ORG Subject: Re: breakage still in sys/systm.h In-Reply-To: <200003242219.RAA46260@khavrinen.lcs.mit.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 24 Mar 2000, Garrett Wollman wrote: > < said: > > > The definitions of major() and minor() in sys/systm.h break usage of the > > header. Since sys/types.h defines major() and minor() as macros which > > compute the major and minor numbers, this creates an order dependency on > > sys/systm.h and sys/types.h. Is this not a bad thing? > > No, since they don't conflict. defines the major and > minor macros iff _KERNEL is not defined, and is a Ah, okay, I see what the problem is with my filesystem driver. Looks like the #define switched from KERNEL to _KERNEL from 3.x to -CURRENT. Thanks. -- Stephen Kiernan stevek@tislabs.com NAI Labs, A Division of Network Associates, Inc. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message