From owner-svn-src-head@freebsd.org Fri Sep 11 12:55:28 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 859C13D92D2; Fri, 11 Sep 2020 12:55:28 +0000 (UTC) (envelope-from gjb@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bnwhw2qKwz4Jh3; Fri, 11 Sep 2020 12:55:28 +0000 (UTC) (envelope-from gjb@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1599828928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tyk3xeaGusj6BLKkfeqYoA1ZlzVsHsxq0WNjfnX7Rn8=; b=LA7KGu9Z9ImY/GILfJh2I2ydOcpa5AQaJoU2DZ2UVu1G+eZm40x/BDJHG0vA65AA0jJT1o /sy5a3202lThe/DO+jA48p5Q6j/dVtIDcXrzYFl3K2HCKFX4m1Ln/vjuLaxyKUsihebVFO bqPI1FnlVk93qSQFDo4OJJFZDuKLbWu9aTwhn7ljBAbYqCYxWjMibOr/pdnzN1056MeNjc vQNyT61bPrsYUnaaLJsse+dCopcCvNoEIN7+65tI2nzGiBtu4gEFsUIxd/2YqvhY15lTUc rzynjza/sGMFMM2w7el3jAFmQKMU+S5Jn+gOOEoxa+y9enfryRnoBKzSbhrHdA== Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id D622D1EA94; Fri, 11 Sep 2020 12:55:27 +0000 (UTC) (envelope-from gjb@freebsd.org) Date: Fri, 11 Sep 2020 12:55:25 +0000 From: Glen Barber To: Ruslan Garipov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364891 - in head: . release release/scripts Message-ID: <20200911125525.GC61041@FreeBSD.org> References: <202008272119.07RLJGgb043888@repo.freebsd.org> <174719d0148.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> <20200909135114.GC61041@FreeBSD.org> <1747c711988.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xVJ7dC7LImzyqkjg" Content-Disposition: inline In-Reply-To: <1747c711988.27b9.e2363f32305322128423a5fd7014e4c4@gmail.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1599828928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tyk3xeaGusj6BLKkfeqYoA1ZlzVsHsxq0WNjfnX7Rn8=; b=JYgZPInvmpEpgbuQtP8Cr3Qf1xM2snfBVS4+n6B4Jw8QfVH7CMT0cMFkpzzGBVtlAUz550 JkdlzI6xFPXgohX6wsQ0euyXHRIS4Xy/EVHyhcwlfdXJHCwLGcMQQIWCfMbCROGp1lRc7p FvL8+wyJ5o6V8Y8YIcZSPwHoarI83QTXZkjIww8SpbH59rvbiI8T5q6Y4+lqBdm2a6Usz/ Ogum/wFLOp8zHsyOhFMu6sJtq8rMf3wJz3HhQ+bIxY2mxzVsz6f4ZVSyWcN4EjjennVu8j QD0zHi9fSe3bPFJG4obE9aKIguWQkABhNKSaQMUJu63zSdb3Fp21dBCg1RUpeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1599828928; a=rsa-sha256; cv=none; b=jKtWArdoD4ET4YuwGrjzPQxT86uwxmlnnRZmdDgf/hxAJU8A5sigSfsquGniE53RI3dB72 SBB1i78yAFyi5qVlZQxHvqpMlIJIfucde4tjRrmNJYdTi4opau+ygSFKSb7vpd1iEe5QPf zFnK3oMPs06Z/E1AZgUxiNK6aDhJjoBz8hB3BG/4wcmNbE+kjvWkR8uukFW22AvhhyecCJ CBIxLItSPexbanw8MfnPzGtyuTxQXAFNlFsk0eOWrzUKNkzD/61s1pss2hNCuv1C0DW84/ jB5Aw9mTJnVzC+GWRV64vuVMnry1M06uxojGyrCUs6yErCMp9a8UOJr6cCWW7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2020 12:55:28 -0000 --xVJ7dC7LImzyqkjg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 11, 2020 at 02:13:41PM +0500, Ruslan Garipov wrote: > On September 9, 2020 6:51:18 PM Glen Barber wrote: >=20 > > On Wed, Sep 09, 2020 at 11:45:49AM +0500, Ruslan Garipov wrote: > > > On August 28, 2020 2:19:33 AM Glen Barber wrote: > > >=20 > > > > Author: gjb > > > > Date: Thu Aug 27 21:19:16 2020 > > > > New Revision: 364891 > > > > URL: https://svnweb.freebsd.org/changeset/base/364891 > > > > > > > > Log: > > > > Merge the projects/release-git branch to head. > > > > This allows building 13.x from Git instead of Subversion. > > > I'm sorry for the late response (and for the bad first one I made on = this > > > commit recently via Gmail web client). > > >=20 > > > My build machine is completely offline. I provide it with fresh snap= shots > > > of the source and ports tree manually -- via tarballs which I'm pulli= ng on > > > a FreeBSD machine having Internet connection. Therefore, neither > > > "/scratch", nor the chrooted environment for me don't require Internet > > > access (I fetch distfiles for offline usage too). > > >=20 > > > Can we somehow remove that requirement for the devel/git port? For > > > example, if one has set all three {SRC,PORTS,DOC}_UPDATE_SKIP variabl= es, > > > then release/release.sh doesn't require devel/git to exist on the hos= t. > > >=20 > > > I really don't need git on my build machine (and don't need it for > > > building). > > >=20 > >=20 > > Can you verify if the attached patch works for your use case? You will > > need to set NOGIT=3D1 in your release.conf. > Partially. It doesn't require devel/git to create the initial build > environment, but it does before beginning cross-build in the > extra_chroot_setup(). >=20 > You check there does the NOGIT have zero length. If NOGIT isn't empty, t= hen > release.sh will ($(which git) returns nothing for me) try to install > devel/git port or package again. And NOGIT isn't empty because in this > function my release.conf was already sourced. So I had removed "not" > (``!'') on line #278, ignoring NOGIT checking, and cross-build started. >=20 Doh! Yeah, that was a mistake - sorry about that. So as far as you are concerned, with the addition of removing the '!', it works as you expect? > It failed eventually on modifications made by r365398, but that's another > story. >=20 > Thanks again, Glen! >=20 Thank you for testing (and finding a silly bug)! Glen --xVJ7dC7LImzyqkjg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl9bc70ACgkQAxRYpUeP 4pNevQ//VaPtQ0h+OCaA1yOXPpWqQ8SLdMyuyO1wE/cXpOQpz9v3o/XP22q/MA7h NVDPxvAgWOP8q3hophjadO2PnzRLVRFcP1k91rVgSscbLqL0nBG0YQF5SBH9Wk48 5Y2G/PSlTwh5KHbWBTfbYUXYeIURWyPTTvfViKzVa7PD88t3ewgLMdaGjagUGr2O 6FwRDpQYtUB9Htgt7jLe+fyEQxNdlJx38tg3GkBoBG+BRdPL7lg0+QF6/WcHQvni wlTigsRlY7r0lKdmA7fxiuNFkhBjQzmP5TtNi6iA9fZNBjdG7CxBJr7salcgrR0G 6UZt+F530n49rWGzRm1gh3zSy59dsBaPIUWTlq+Rigq9hnx9jP/lxdImBz7Bi8SF EfbcckaL/W+spL0sUJihNwyyGNuJJ2EV1UivQzMZxZdEhF6/sFMRAcNr7O0CAAlj qvrFbQdzY0YyVv7A6I+LYNSqxEWvNnmcGVYmtsn4/0W0a4KsqO3upfyeKCMJmndC Qe5dxBjXkbMJMae9htmhI1Iwim8nMM2B0yIJPLAx19lw/DNEA+XSHld4EvVqyoOj ZcI95MhiEud0zUfCfR3EuHaI6DvjlLSqBIpQutiJCG6r0jU7DkehfDiMFzCr/dIG 8KHOHDomOmayxrHkfHphKmv4IX9L9ctVaYR638Z4wr0oLCt4ddM= =qzpp -----END PGP SIGNATURE----- --xVJ7dC7LImzyqkjg--