From nobody Wed Feb 11 10:03:02 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9vBZ3B87z6SMZQ for ; Wed, 11 Feb 2026 10:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9vBZ0ycRz487f for ; Wed, 11 Feb 2026 10:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770804182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=taf9mJvfvdhouHmzhgOvP840RzMmw9Va/xjA9lHXoSg=; b=IZsK+vfpzA7AL+an3fFAf+PPdBXUDPNj+pHCAb4SXsPxaI43ohcS7d57jZ3/WD3ALot4md vhlXcEq7kHavatGWbjnSyYOBGsj2CTuI/B/SyIsO8n1/wm8fxtC6TxngWIGdM3LfwfrFi1 5G3OXkIKtzFLXHil6idM8BvwyjmhTyg577546G7rPGyLeqVlNbWKXHazUECBPeDk0wLz9P IRixQBLZlSWxUfuZh+jZZMaQH7wvhzCpaYS2O+c28mZYA0WQpJ3Jk4+HP09NSOD7pyC3gn dLmlfhjkjDuiQDoAGsSAdOuYhSXZBeriLj+5aC1BzjEuRrpY+X1VmKgFEOnVvQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770804182; a=rsa-sha256; cv=none; b=XLUYTM/vBxJOa68GU4BPe86IXanl4UtA5VHel2rNIwpgru0TPCww25VPTm7mOy+4UgF/4P J492KUAHiODLgWT0M4vwniOPEY94CHgpP36Tb2X2yHWf6Zb0qndhQ6oY4U8HjnnJA1BbVo 3A45BFNE/k300za7CvTYbTwVVw+3zVyja0Y5DSbsk0w4Xah/ExknHomNJ5sjPfICwF9gqS 1qgASZBdwXtqM2w0bYJy9aO6/TQJHeM91V6ovatQf5xxxhgf5SnInPgDzFR7VaTQIPBDGE gmiDV59kPxYjlFteZv0HaixDdxCd1oispzP6QleYFdV7v5o1/A3rSBXQFkATnA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770804182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=taf9mJvfvdhouHmzhgOvP840RzMmw9Va/xjA9lHXoSg=; b=xo0nfSXnFcHiI4wfQTLZmq8vUg+ih8WQJ3Cf1RZiUEQahL8o5nf30ozDWiyMDUi249pVEk Lg01ywyifcYibDFrPHwsrGB1iScQPymQ/Np7AkiwAwb4grr0gjewKSodczp//uCpynWSIX Vutsig/QZ24F640EP0RqljFq+yYKSdYG1JPV8PaL3RS7DgOlAtJgD7jvPnafh0LAuqxgYA /l/+y7+B85Tbg8pianZjiBGCFXnVA4LJWhufwv7xhIoOMxiKNmUTwIYqfb0PLzPhTibExH svteTdXBpmWqnqdpJiTMD8XGbK1cIkQMIUkCctHcu7EWrfqbFkih55yffeLwiA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9vBZ0Nb8zlc7 for ; Wed, 11 Feb 2026 10:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1cb8d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 10:03:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 23ffd1650cc4 - stable/15 - qlnxe: Remove a pointless copy back from the link-layer address List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 23ffd1650cc431e762387d384ede99ae085bc130 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 10:03:02 +0000 Message-Id: <698c53d6.1cb8d.57f20763@gitrepo.freebsd.org> The branch stable/15 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=23ffd1650cc431e762387d384ede99ae085bc130 commit 23ffd1650cc431e762387d384ede99ae085bc130 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-11 10:00:42 +0000 qlnxe: Remove a pointless copy back from the link-layer address On ifnet attaching, ether_ifattach() makes the link-layer address by shadow copying the ha->primary_mac. Well, the link-layer address will not be altered during attaching, thus it is pointless to copy it back. No functional change intended. Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54883 (cherry picked from commit 4ac3081b282800158df7abe93f307d76e1b5b808) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 99110e5e2d8f..9616d9f4d611 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2392,8 +2392,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); ether_ifattach(ifp, ha->primary_mac); - bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - QL_DPRINT2(ha, "exit\n"); return;