From owner-svn-src-all@freebsd.org  Sat Jul  9 02:33:47 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17F58B852E4;
 Sat,  9 Jul 2016 02:33:47 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DE7C214B4;
 Sat,  9 Jul 2016 02:33:46 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u692XkYf089595;
 Sat, 9 Jul 2016 02:33:46 GMT (envelope-from pfg@FreeBSD.org)
Received: (from pfg@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u692XkqD089593;
 Sat, 9 Jul 2016 02:33:46 GMT (envelope-from pfg@FreeBSD.org)
Message-Id: <201607090233.u692XkqD089593@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: pfg set sender to pfg@FreeBSD.org
 using -f
From: "Pedro F. Giffuni" <pfg@FreeBSD.org>
Date: Sat, 9 Jul 2016 02:33:46 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r302476 - head/sys/net
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jul 2016 02:33:47 -0000

Author: pfg
Date: Sat Jul  9 02:33:45 2016
New Revision: 302476
URL: https://svnweb.freebsd.org/changeset/base/302476

Log:
  ng_mppc(4):: basic readability cleanups.
  
  In particular use __unreachable() to appease static analyzers.
  No functional change.
  
  CID:		1356591
  MFC after:	3 days

Modified:
  head/sys/net/mppcc.c
  head/sys/net/mppcd.c

Modified: head/sys/net/mppcc.c
==============================================================================
--- head/sys/net/mppcc.c	Sat Jul  9 00:35:20 2016	(r302475)
+++ head/sys/net/mppcc.c	Sat Jul  9 02:33:45 2016	(r302476)
@@ -232,8 +232,9 @@ int MPPC_Compress(u_char **src, u_char *
 	} else if (off < 8192) {	/* 16-bit offset; 320 <= offset < 8192 */
 	    putbits16(*dst, 0xc000|(off-320), 16, &olen, &l);
 	} else {		/* NOTREACHED */
+	    __unreachable();
 	    rtn &= ~MPPC_OK;
-	    return rtn;
+	    return (rtn);
 	}
 
 	/* Encode length of match. */

Modified: head/sys/net/mppcd.c
==============================================================================
--- head/sys/net/mppcd.c	Sat Jul  9 00:35:20 2016	(r302475)
+++ head/sys/net/mppcd.c	Sat Jul  9 02:33:45 2016	(r302476)
@@ -170,7 +170,7 @@ int MPPC_Decompress(u_char **src, u_char
 			rtn &= ~MPPC_OK;
 			return (rtn);
 		    }
-		} else {		/* NOTREACHED */
+		} else {		/* This shouldn't happen. */
 		    rtn &= ~MPPC_OK;
 		    return (rtn);
 		}