From owner-svn-src-all@FreeBSD.ORG Wed Nov 6 06:42:10 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D7BDACB2; Wed, 6 Nov 2013 06:42:10 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 509992593; Wed, 6 Nov 2013 06:42:09 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id rA66g7B0013800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 6 Nov 2013 10:42:07 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id rA66g7Lv013799; Wed, 6 Nov 2013 10:42:07 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 6 Nov 2013 10:42:07 +0400 From: Gleb Smirnoff To: Peter Wemm Subject: Re: svn commit: r257696 - in head: libexec/rbootd share/man/man9 sys/compat/svr4 sys/net sys/sys Message-ID: <20131106064207.GQ7577@FreeBSD.org> References: <201311051029.rA5ATmmM017799@svn.freebsd.org> <201311051447.52382.jhb@freebsd.org> <20131105204217.GK7577@FreeBSD.org> <201311051718.26356.jhb@freebsd.org> <52798A09.5020303@wemm.org> <52798EA3.2060407@wemm.org> <20131106061115.GO7577@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131106061115.GO7577@FreeBSD.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Nov 2013 06:42:10 -0000 On Wed, Nov 06, 2013 at 10:11:15AM +0400, Gleb Smirnoff wrote: T> On Tue, Nov 05, 2013 at 04:34:43PM -0800, Peter Wemm wrote: T> P> > eg: /usr/sbin/traceroute after the change: T> P> > # traceroute www.freebsd.org T> P> > traceroute: ifaddrlist: SIOCGIFADDR: bge0: Can't assign requested address T> P> > T> P> > Hint: linux doesn't have a sa_len, so code that originates on Linux T> P> > will no longer work. The code glebius removed used to work around this. T> P> > T> P> > This is not old binaries, this is binaries compiled *today*. T> P> > T> P> I may have to take this back. I mis-read the removed code for T> P> SIOCSIFADDR etc that had the sa_len emulation in it. I might be hitting T> P> a bug in r257692 ("rewrite in_control"). T> P> T> P> I will check and report back. My apologies for potentially jumping the T> P> gun on this. T> T> Yes, much more probable that this is a regression from my in_control() T> rewrite. Sorry. I will look at this today. Oh, a terrible braino from me. I'll fix it today. -- Totus tuus, Glebius.