From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jan 31 07:40:15 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 94C1516A420 for ; Tue, 31 Jan 2006 07:40:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E1F243D6D for ; Tue, 31 Jan 2006 07:40:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0V7e3dO033673 for ; Tue, 31 Jan 2006 07:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0V7e3lq033669; Tue, 31 Jan 2006 07:40:03 GMT (envelope-from gnats) Resent-Date: Tue, 31 Jan 2006 07:40:03 GMT Resent-Message-Id: <200601310740.k0V7e3lq033669@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michael Nottebrock Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB76E16A420 for ; Tue, 31 Jan 2006 07:36:58 +0000 (GMT) (envelope-from lofi@freebsd.org) Received: from mail-in-01.arcor-online.net (mail-in-01.arcor-online.net [151.189.21.41]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1779F43D48 for ; Tue, 31 Jan 2006 07:36:58 +0000 (GMT) (envelope-from lofi@freebsd.org) Received: from mail-in-09-z2.arcor-online.net (mail-in-09-z2.arcor-online.net [151.189.8.21]) by mail-in-01.arcor-online.net (Postfix) with ESMTP id EBADCB383C for ; Tue, 31 Jan 2006 08:36:56 +0100 (CET) Received: from mail-in-03.arcor-online.net (mail-in-06.arcor-online.net [151.189.21.46]) by mail-in-09-z2.arcor-online.net (Postfix) with ESMTP id B5F94896A8 for ; Tue, 31 Jan 2006 08:36:56 +0100 (CET) Received: from lofi.dyndns.org (dslb-084-061-156-194.pools.arcor-ip.net [84.61.156.194]) by mail-in-03.arcor-online.net (Postfix) with ESMTP id 7E2A91126CF for ; Tue, 31 Jan 2006 08:36:56 +0100 (CET) Received: from vm-kiste.my.domain (root@vm-kiste.my.domain [192.168.8.6]) by lofi.dyndns.org (8.13.4/8.13.3) with ESMTP id k0V7asjG078267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 31 Jan 2006 08:36:54 +0100 (CET) (envelope-from lofi@freebsd.org) Received: from vm-kiste.my.domain (lofi@localhost [127.0.0.1]) by vm-kiste.my.domain (8.13.4/8.13.4) with ESMTP id k0V7ar6Z089945 for ; Tue, 31 Jan 2006 08:36:53 +0100 (CET) (envelope-from lofi@vm-kiste.my.domain) Received: (from lofi@localhost) by vm-kiste.my.domain (8.13.4/8.13.4/Submit) id k0V7arps089944; Tue, 31 Jan 2006 08:36:53 +0100 (CET) (envelope-from lofi) Message-Id: <200601310736.k0V7arps089944@vm-kiste.my.domain> Date: Tue, 31 Jan 2006 08:36:53 +0100 (CET) From: Michael Nottebrock To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/92586: Don't warn about libtool archives for KDE ports. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Michael Nottebrock List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2006 07:40:15 -0000 >Number: 92586 >Category: ports >Synopsis: Don't warn about libtool archives for KDE ports. >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jan 31 07:40:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Michael Nottebrock >Release: FreeBSD 5.4-STABLE i386 >Organization: >Environment: System: FreeBSD vm-kiste 5.4-STABLE FreeBSD 5.4-STABLE #1: Sun Oct 16 18:16:21 CEST 2005 root@kiste:/usr/obj/usr/src/sys/KISTE-UP i386 >Description: Portlint in maintainer mode currently warns about libtool archives in pkg-plist. KDE applications however need those for correct operation (and bsd.autotools.mk will in fact prevent ports with both USE_KDELIBS_VER and USE_AUTOTOOLS=libtool set from building soon). The attached patch disables the warning if USE_KDELIBS_VER is set in a port's Makefile. >How-To-Repeat: >Fix: --- portlint.pl.diff begins here --- Index: portlint.pl =================================================================== RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v retrieving revision 1.83 diff -u -r1.83 portlint.pl --- portlint.pl 22 Jan 2006 00:45:00 -0000 1.83 +++ portlint.pl 31 Jan 2006 07:04:17 -0000 @@ -176,7 +176,7 @@ PKGDIR COMMENT DESCR PLIST PKGCATEGORY PKGINSTALL PKGDEINSTALL PKGREQ PKGMESSAGE MD5_FILE .CURDIR INSTALLS_SHLIB USE_AUTOTOOLS INDEXFILE PKGORIGIN CONFLICTS PKG_VERSION PKGINSTALLVER - PLIST_FILES OPTIONS INSTALLS_OMF + PLIST_FILES OPTIONS INSTALLS_OMF USE_KDELIBS_VER ); my $cmd = join(' -V ', "make $makeenv MASTER_SITE_BACKUP=''", @varlist); @@ -667,7 +667,7 @@ "for more details."); } - if ($_ =~ /\.la$/ && $makevar{USE_AUTOTOOLS} =~ 'libtool') { + if ($_ =~ /\.la$/ && $makevar{USE_AUTOTOOLS} =~ 'libtool' && !defined($makevar{USE_KDELIBS_VER})) { &perror("WARN: $file [$.]: installing libtool archives, ". "please use USE_AUTOTOOLS in Makefile if possible. ". "See http://www.FreeBSD.org/gnome/docs/porting.html ". --- portlint.pl.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: